Implement proper NO_METADATA support for cassandra protocol #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorbros
reviewed
Nov 21, 2022
conorbros
approved these changes
Nov 21, 2022
benbromhead
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #905
I originally thought this would be more involved because I thought the encode logic needed to special case NO_METADATA just like we do for decoding.
But it turns out that the standard implementation for encoding null and bytes data types works just fine with the null and bytes types that we generate for NO_METADATA decoding.
To prove this I added
DebugForceEncodeto cassandra-cluster-v4.I think its fine to add this to an existing test because we have the very similar cassandra-cluster-multi-rack test case which will test CassandraSinkCluster without the DebugForceEncode.