More routing tests and bug fix #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
conorbros
commented
Nov 22, 2022
conorbros
commented
- Add routing tests for compound and composite primary keys.
- Fix a bug in the routing key serialising
- Add tests against cdrs-tokio aswell
conorbros
force-pushed
the
prepared-tests
branch
from
69600a4
to
6e37c7f
Compare
rukai
reviewed
Nov 22, 2022
shotover-proxy/tests/cassandra_int_tests/cluster/single_rack_v4.rs
Outdated
Show resolved
Hide resolved
rukai
reviewed
Nov 22, 2022
rukai
reviewed
Nov 22, 2022
shotover-proxy/src/transforms/cassandra/sink_cluster/routing_key.rs
Outdated
Show resolved
Hide resolved
rukai
reviewed
Nov 22, 2022
rukai
reviewed
Nov 23, 2022
rukai
reviewed
Nov 23, 2022
conorbros
force-pushed
the
prepared-tests
branch
from
1539ca9
to
580a005
Compare
rukai
approved these changes
Nov 23, 2022
XA21X
approved these changes
Nov 24, 2022
conorbros
force-pushed
the
prepared-tests
branch
from
580a005
to
2fe792d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.