Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connection shutdown logic #933

Merged
merged 4 commits into from Dec 8, 2022
Merged

Fix connection shutdown logic #933

merged 4 commits into from Dec 8, 2022

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 23, 2022 •
edited

Previously we were shutting down the base chain from which all real chains are cloned from.
That was pretty pointless because messages are never sent down that chain.

This PR has two fixes:

  • We keep track of active connections and wait for them to shutdown before killing the tokio runtime. (the join_all in shutdown())
  • We send the flush message in every connection when the connection is terminated.

@rukai rukai mentioned this pull request Nov 23, 2022
Closed
@rukai rukai requested a review from conorbros November 23, 2022 04:15
@rukai rukai mentioned this pull request Nov 23, 2022
Closed
This was referenced Nov 23, 2022
Merged
Merged
@rukai rukai force-pushed the fix_connection_shutdown branch 2 times, most recently from 5424bec to 1e21263 Compare December 8, 2022 03:13
@rukai rukai enabled auto-merge (squash) December 8, 2022 03:51
@rukai rukai merged commit f4d014b into shotover:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbromhead benbromhead benbromhead approved these changes

@conorbros conorbros conorbros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rukai @benbromhead @conorbros