Fix propagating tracing spans into subchains #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
commented
Nov 24, 2022
rukai
force-pushed
the
tracing_span_fixes
branch
from
24d7c88
to
0659c8f
Compare
conorbros
approved these changes
Nov 24, 2022
benbromhead
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task for the Tee transforms BufferedChain is generated during the
.clone_with_pushed_messages_tx(pushed_messages_tx.clone()),line (previously line 215)By extending the async instrument call to run an async scope that includes that line, we include the task within our span, therefore improving our tracing results.
Sample without this PR:
Sample with this PR:
Still a few cases where its missing that will need to be investigated separately.
Make sure to turn on "hide whitespace" for a much better diff