Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass flush flag through sub chains #937

Merged
merged 7 commits into from Dec 12, 2022
Merged

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 24, 2022

process_request_no_return needs some special handling to actually wait for a return on a flush message, which it then ignores.
The wait is purely to ensure the operation completes before shotover shutsdown.
This should be fine performance wise as it only occurs once when the connection is closed and the client isnt waiting on a message response at that point.

@rukai rukai requested a review from conorbros December 9, 2022 06:09
@conorbros conorbros enabled auto-merge (squash) December 12, 2022 04:07
@github-actions
Copy link

1 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/3672532855

  1 (1.00%) high severe
redis/active_get        time:   [339.59 µs 342.44 µs 347.45 µs]
                        thrpt:  [2.8781 Kelem/s 2.9202 Kelem/s 2.9447 Kelem/s]
                 change:
                        time:   [+22.024% +25.991% +30.086%] (p = 0.00 < 0.05)
                        thrpt:  [-23.128% -20.629% -18.049%]
                        Performance has regressed.

@conorbros conorbros merged commit 176d12c into shotover:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants