Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cassandra-stress fix #956

Merged
merged 3 commits into from Dec 14, 2022
Merged

cassandra-stress fix #956

merged 3 commits into from Dec 14, 2022

Conversation

conorbros
Copy link
Member

@conorbros conorbros commented Dec 9, 2022 •
edited by rukai

closes #949

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

1 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/3654796909

  2 (2.00%) high severe
redis/active_get        time:   [269.84 µs 279.46 µs 289.73 µs]
                        thrpt:  [3.4515 Kelem/s 3.5783 Kelem/s 3.7060 Kelem/s]
                 change:
                        time:   [+21.186% +25.150% +29.361%] (p = 0.00 < 0.05)
                        thrpt:  [-22.697% -20.096% -17.482%]
                        Performance has regressed.

@rukai
Copy link
Member

rukai commented Dec 12, 2022

The Cargo.lock is missing the update to cassandra-protocol (hence the CI failure)

@conorbros
Copy link
Member Author

The changes were only merged into cdrs-tokio main, I've asked for them to be merged into the 8.0 branch.

rukai
rukai reviewed Dec 13, 2022
View reviewed changes
shotover-proxy/Cargo.toml Outdated Show resolved Hide resolved
rukai
rukai approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work figuring this out!

@rukai rukai enabled auto-merge (squash) December 14, 2022 01:36
@rukai rukai merged commit ab7aaba into shotover:main Dec 14, 2022
@conorbros conorbros deleted the mumur3-fix branch December 14, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rukai rukai rukai approved these changes

@benbromhead benbromhead benbromhead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Murmur3token size panic
3 participants
@conorbros @rukai @benbromhead