Fix intermittent failure when using cdrs driver #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
commented
Dec 14, 2022
rukai
force-pushed
the
fix_intermittent_cdrs_failure
branch
6 times, most recently
from
3e221f3
to
14c7947
Compare
rukai
force-pushed
the
fix_intermittent_cdrs_failure
branch
from
14c7947
to
b79514a
Compare
benbromhead
approved these changes
Dec 20, 2022
conorbros
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #958
The issue was caused by a bug in cdrs-tokio which I have submitted upstream here: krojew/cdrs-tokio#136
As a bonus we were able to remove some sleeps we previously needed, taking about ~40s (4*10s) off our total test runtime.