Avoid allocating for table name comparisons #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorbros
approved these changes
Dec 21, 2022
benbromhead
approved these changes
Dec 21, 2022
rukai
force-pushed
the
const_table_names
branch
from
a3d3484
to
e51d574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prereq: shotover/rust-cql3-parser#36
Makes use of the soon to be added
IdentifierRefandFQNameReftypes to avoid allocating when creating a value just for comparison purposes.I also changed every
Unquotedto aQuotedbecause that will avoid an allocation within thepartial_eqimplementation.