Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUPPORTED rewrite #991

Merged
merged 7 commits into from Jan 31, 2023
Merged

SUPPORTED rewrite #991

merged 7 commits into from Jan 31, 2023

Conversation

conorbros
Copy link
Member

@conorbros conorbros commented Jan 24, 2023 •
edited

Rewrite the SUPPORTED response to OPTIONS Cassandra frames to remove all compression options.

@conorbros conorbros mentioned this pull request Jan 24, 2023
Closed
@conorbros conorbros marked this pull request as ready for review January 25, 2023 04:23
@conorbros conorbros requested a review from rukai January 27, 2023 04:57
@rukai
Copy link
Member

rukai commented Jan 27, 2023

I dont think disabling compression is sufficient reason to introduce an entire new transform into our API.
And even then we cant expect the user to know that we dont support compression and so they must configure this undocumented transform in order to force the client to avoid compression.

If we must urgently implement this functionality before implementing proper compression support it should go into the protocol level or into our sink transforms.
I suspect we would be better off just implementing compression support though.

@conorbros conorbros changed the title Options rewrite transform SUPPORTED rewrite Jan 30, 2023
rukai
rukai approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rukai rukai enabled auto-merge (squash) January 31, 2023 00:45
@rukai rukai merged commit 2664fa8 into shotover:main Jan 31, 2023
@conorbros conorbros deleted the options-rewrite-transform branch January 31, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rukai rukai rukai approved these changes

@benbromhead benbromhead benbromhead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@conorbros @rukai @benbromhead