Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDIM sampling eta setting #48

Open
pinecho opened this issue Jan 6, 2023 · 1 comment
Open

DDIM sampling eta setting #48

pinecho opened this issue Jan 6, 2023 · 1 comment

Comments

@pinecho
Copy link

pinecho commented Jan 6, 2023

Hi, thanks for your great work.
I noticed that you applied DDIM sampling method in your code, with the setting:

self.ddim_sampling_eta = 1.

I found ETA controls the scale of the variance (0 is DDIM, and 1 is one type of DDPM). from https://github.com/ermongroup/ddim
It seems that eta=1 means DDPM.
May I ask if your eta is the same as the one from ermongroup?

@ShoufaChen
Copy link
Owner

Hi,

Thanks for your interest.

We have experimented with several eta values. The results demonstrate that eta has negligible influence on the final results. Therefore, we adopt ddim_sampling_eta = 1. as our default setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants