Small repo goodies

shouldjs · Aug 13, 2015 · fc3d799 · fc3d799
1 parent eb63707
commit fc3d799
Show file tree

Hide file tree

Showing 15 changed files with 31 additions and 27 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -6,7 +6,8 @@
     "eqeqeq": [2, "smart"],
     "curly": 0,
     "no-wrap-func": 0,
-    "no-underscore-dangle": 0
+    "no-underscore-dangle": 0,
+    "yoda": 0
   },
   "env": {
     "node": true,

diff --git a/gulpfile.js b/gulpfile.js
@@ -1,15 +1,18 @@
 var gulp = require('gulp');
-var $ = require('gulp-load-plugins')({lazy: false});
 
-var source = require('vinyl-source-stream2');
-var browserify = require('browserify');
+var header = require('gulp-header');
+var uglify = require('gulp-uglify');
+var rename = require('gulp-rename');
+
+var source = require('vinyl-source-stream');
+var buffer = require('vinyl-buffer');
 
-var path = require('path');
+var browserify = require('browserify');
 
 var pkg = require('./package.json');
 
 var banner = [
-  '/*',
+  '/*!',
   ' * <%= pkg.name %> - <%= pkg.description %>',
   ' * @version v<%= pkg.version %>',
   ' * @author <%= pkg.author %>',
@@ -31,10 +34,10 @@ gulp.task('script', function() {
 
   return bundleStream
     .pipe(source('should.js'))
-    .pipe($.header(banner, {pkg: pkg}))
+    .pipe(buffer())
+    .pipe(header(banner, {pkg: pkg}))
     .pipe(gulp.dest('./'))
-    .pipe($.uglify())
-    .pipe($.header(banner, {pkg: pkg}))
-    .pipe($.rename('should.min.js'))
+    .pipe(uglify({ preserveComments: 'some' }))
+    .pipe(rename('should.min.js'))
     .pipe(gulp.dest('./'));
 });
diff --git a/lib/ext/assert.js b/lib/ext/assert.js
@@ -1,4 +1,4 @@
-/*!
+/*
  * Should
  * Copyright(c) 2010-2014 TJ Holowaychuk <tj@vision-media.ca>
  * MIT Licensed

diff --git a/lib/ext/bool.js b/lib/ext/bool.js
@@ -1,4 +1,4 @@
-/*!
+/*
  * Should
  * Copyright(c) 2010-2014 TJ Holowaychuk <tj@vision-media.ca>
  * MIT Licensed

diff --git a/lib/ext/contain.js b/lib/ext/contain.js
@@ -1,4 +1,4 @@
-/*!
+/*
  * Should
  * Copyright(c) 2010-2014 TJ Holowaychuk <tj@vision-media.ca>
  * MIT Licensed

diff --git a/lib/ext/eql.js b/lib/ext/eql.js
@@ -1,4 +1,4 @@
-/*!
+/*
  * Should
  * Copyright(c) 2010-2014 TJ Holowaychuk <tj@vision-media.ca>
  * MIT Licensed

diff --git a/lib/ext/error.js b/lib/ext/error.js
@@ -1,4 +1,4 @@
-/*!
+/*
  * Should
  * Copyright(c) 2010-2014 TJ Holowaychuk <tj@vision-media.ca>
  * MIT Licensed

diff --git a/lib/ext/match.js b/lib/ext/match.js
@@ -1,4 +1,4 @@
-/*!
+/*
  * Should
  * Copyright(c) 2010-2014 TJ Holowaychuk <tj@vision-media.ca>
  * MIT Licensed
@@ -75,7 +75,7 @@ module.exports = function(should, Assertion) {
           if(matchedProps.length)
             this.params.operator += '\n    matched properties: ' + matchedProps.join(', ');
 
-          this.assert(notMatchedProps.length == 0);
+          this.assert(notMatchedProps.length === 0);
         } // should we try to convert to String and exec?
       } else if(typeof other == 'function') {
         var res;
@@ -112,7 +112,7 @@ module.exports = function(should, Assertion) {
         if(matchedProps.length)
           this.params.operator += '\n    matched properties: ' + matchedProps.join(', ');
 
-        this.assert(notMatchedProps.length == 0);
+        this.assert(notMatchedProps.length === 0);
       } else {
         this.assert(false);
       }

diff --git a/lib/ext/number.js b/lib/ext/number.js
@@ -1,4 +1,4 @@
-/*!
+/*
  * Should
  * Copyright(c) 2010-2014 TJ Holowaychuk <tj@vision-media.ca>
  * MIT Licensed

diff --git a/lib/ext/property.js b/lib/ext/property.js
@@ -1,4 +1,4 @@
-/*!
+/*
  * Should
  * Copyright(c) 2010-2014 TJ Holowaychuk <tj@vision-media.ca>
  * MIT Licensed

diff --git a/lib/ext/string.js b/lib/ext/string.js
@@ -1,4 +1,4 @@
-/*!
+/*
  * Should
  * Copyright(c) 2010-2014 TJ Holowaychuk <tj@vision-media.ca>
  * MIT Licensed

diff --git a/lib/ext/type.js b/lib/ext/type.js
@@ -1,4 +1,4 @@
-/*!
+/*
  * Should
  * Copyright(c) 2010-2014 TJ Holowaychuk <tj@vision-media.ca>
  * MIT Licensed

diff --git a/lib/should.js b/lib/should.js
@@ -1,4 +1,4 @@
-/*!
+/*
  * Should
  * Copyright(c) 2010-2014 TJ Holowaychuk <tj@vision-media.ca>
  * MIT Licensed

diff --git a/lib/util.js b/lib/util.js
@@ -1,4 +1,4 @@
-/*!
+/*
  * Should
  * Copyright(c) 2010-2014 TJ Holowaychuk <tj@vision-media.ca>
  * MIT Licensed

diff --git a/package.json b/package.json
@@ -15,15 +15,15 @@
   },
   "devDependencies": {
     "browserify": "latest",
+    "eslint": "latest",
     "gulp": "^3.8.10",
     "gulp-header": "^1.2.2",
-    "gulp-load-plugins": "^0.5.1",
     "gulp-rename": "^1.2.0",
     "gulp-uglify": "^1.0.1",
-    "gulp-util": "^2.2.14",
     "mocha": "latest",
     "mocha-better-spec-reporter": "latest",
-    "vinyl-source-stream2": "^0.1.1",
+    "vinyl-buffer": "^1.0.0",
+    "vinyl-source-stream": "^1.1.0",
     "zuul": "latest"
   },
   "keywords": [