Skip to content

Commit

Permalink
Removed member private keyword, added internal for class
Browse files Browse the repository at this point in the history
  • Loading branch information
JakeGinnivan committed Nov 21, 2015
1 parent cd10781 commit 7b8f15b
Show file tree
Hide file tree
Showing 46 changed files with 85 additions and 85 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public class ClassScenario : ShouldlyShouldTestScenario
{ThingKey, new MyThing()}
};

private static readonly MyThing ThingKey = new MyThing();
static readonly MyThing ThingKey = new MyThing();

protected override void ShouldThrowAWobbly()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ namespace Shouldly.Tests.Dictionaries.ShouldContainKey
{
public class GuidScenario : ShouldlyShouldTestScenario
{
private readonly Dictionary<Guid, Guid> _dictionary = new Dictionary<Guid, Guid>
readonly Dictionary<Guid, Guid> _dictionary = new Dictionary<Guid, Guid>
{
{ GuidKey, Guid.NewGuid()}
};

private static readonly Guid GuidKey = Guid.NewGuid();
private readonly Guid _missingGuid = new Guid("5250646b-4c46-4b0e-86d8-e1421f2a0ea2");
static readonly Guid GuidKey = Guid.NewGuid();
readonly Guid _missingGuid = new Guid("5250646b-4c46-4b0e-86d8-e1421f2a0ea2");

protected override void ShouldThrowAWobbly()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Shouldly.Tests.Dictionaries.ShouldContainKey
{
public class StringScenario : ShouldlyShouldTestScenario
{
private readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
{
{ "Foo", ""}
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ public class ClassScenario : ShouldlyShouldTestScenario
{ThingKey, ThingValue}
};

private static readonly MyThing ThingKey = new MyThing();
private static readonly MyThing ThingValue = new MyThing();
static readonly MyThing ThingKey = new MyThing();
static readonly MyThing ThingValue = new MyThing();

protected override void ShouldThrowAWobbly()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ namespace Shouldly.Tests.Dictionaries.ShouldContainKeyAndValue
{
public class GuidScenario : ShouldlyShouldTestScenario
{
private readonly Dictionary<Guid, Guid> _dictionary = new Dictionary<Guid, Guid>
readonly Dictionary<Guid, Guid> _dictionary = new Dictionary<Guid, Guid>
{
{ GuidKey, GuidValue}
};

private static readonly Guid GuidKey = Guid.NewGuid();
private static readonly Guid GuidValue = Guid.NewGuid();
private readonly Guid _missingGuidKey = new Guid("1924e617-2fc2-47ae-ad38-b6f30ec2226b");
private readonly Guid _missingGuidValue = new Guid("F08A0B08-C9F4-49BB-A4D4-BE06E88B69C8");
static readonly Guid GuidKey = Guid.NewGuid();
static readonly Guid GuidValue = Guid.NewGuid();
readonly Guid _missingGuidKey = new Guid("1924e617-2fc2-47ae-ad38-b6f30ec2226b");
readonly Guid _missingGuidValue = new Guid("F08A0B08-C9F4-49BB-A4D4-BE06E88B69C8");

protected override void ShouldThrowAWobbly()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ public class OnlyKeyMatches : ShouldlyShouldTestScenario
{ThingKey, ThingValue}
};

private static readonly MyThing ThingKey = new MyThing();
private static readonly MyThing ThingValue = new MyThing();
static readonly MyThing ThingKey = new MyThing();
static readonly MyThing ThingValue = new MyThing();

protected override void ShouldThrowAWobbly()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ public class OnlyValueMatches : ShouldlyShouldTestScenario
{ThingKey, ThingValue}
};

private static readonly MyThing ThingKey = new MyThing();
private static readonly MyThing ThingValue = new MyThing();
static readonly MyThing ThingKey = new MyThing();
static readonly MyThing ThingValue = new MyThing();

protected override void ShouldThrowAWobbly()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Shouldly.Tests.Dictionaries.ShouldContainKeyAndValue
{
public class StringScenario : ShouldlyShouldTestScenario
{
private readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
{
{ "Foo", "Bar"}
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Shouldly.Tests.Dictionaries.ShouldContainKeyAndValue
{
public class StringScenario_OnlyKeyMatches : ShouldlyShouldTestScenario
{
private readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
{
{ "Foo", "Bar"}
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Shouldly.Tests.Dictionaries.ShouldContainKeyAndValue
{
public class StringScenario_OnlyValueMatches : ShouldlyShouldTestScenario
{
private readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
{
{ "Foo", "Bar"}
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ public class ValueIsNull : ShouldlyShouldTestScenario
{ThingKey, ThingValue}
};

private static readonly MyThing ThingKey = new MyThing();
private static readonly MyThing ThingValue = null;
static readonly MyThing ThingKey = new MyThing();
static readonly MyThing ThingValue = null;

protected override void ShouldThrowAWobbly()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public class ClassScenario : ShouldlyShouldTestScenario
{ThingKey, new MyThing()}
};

private static readonly MyThing ThingKey = new MyThing();
static readonly MyThing ThingKey = new MyThing();

protected override void ShouldThrowAWobbly()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ namespace Shouldly.Tests.Dictionaries.ShouldNotContainKey
{
public class GuidScenario : ShouldlyShouldTestScenario
{
private readonly Dictionary<Guid, Guid> _dictionary = new Dictionary<Guid, Guid>
readonly Dictionary<Guid, Guid> _dictionary = new Dictionary<Guid, Guid>
{
{ GuidKey, Guid.NewGuid()}
};

private static readonly Guid GuidKey = new Guid("89bdbe3d-3436-4749-bcb7-84264394026c");
static readonly Guid GuidKey = new Guid("89bdbe3d-3436-4749-bcb7-84264394026c");

protected override void ShouldThrowAWobbly()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Shouldly.Tests.Dictionaries.ShouldNotContainKey
{
public class StringScenario : ShouldlyShouldTestScenario
{
private readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
{
{ "Foo", ""}
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ public class ClassScenario : ShouldlyShouldTestScenario
{ThingKey, ThingValue}
};

private static readonly MyThing ThingKey = new MyThing();
private static readonly MyThing ThingValue = new MyThing();
static readonly MyThing ThingKey = new MyThing();
static readonly MyThing ThingValue = new MyThing();

protected override void ShouldThrowAWobbly()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ namespace Shouldly.Tests.Dictionaries.ShouldNotContainValueForKey
{
public class GuidScenario : ShouldlyShouldTestScenario
{
private readonly Dictionary<Guid, Guid> _dictionary = new Dictionary<Guid, Guid>
readonly Dictionary<Guid, Guid> _dictionary = new Dictionary<Guid, Guid>
{
{ GuidKey, GuidValue}
};

private static readonly Guid GuidKey = new Guid("edae0d73-8e4c-4251-85c8-e5497c7ccad1");
private static readonly Guid GuidValue = new Guid("fa1e5f58-578f-43d4-b4d6-67eae06a5d17");
static readonly Guid GuidKey = new Guid("edae0d73-8e4c-4251-85c8-e5497c7ccad1");
static readonly Guid GuidValue = new Guid("fa1e5f58-578f-43d4-b4d6-67eae06a5d17");

protected override void ShouldThrowAWobbly()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ public class KeyAndValueExist : ShouldlyShouldTestScenario
{ThingKey, ThingValue}
};

private static readonly MyThing ThingKey = new MyThing();
private static readonly MyThing ThingValue = new MyThing();
static readonly MyThing ThingKey = new MyThing();
static readonly MyThing ThingValue = new MyThing();

protected override void ShouldThrowAWobbly()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ public class NoKeyExists : ShouldlyShouldTestScenario
{ThingKey, ThingValue}
};

private static readonly MyThing ThingKey = new MyThing();
private static readonly MyThing ThingValue = new MyThing();
static readonly MyThing ThingKey = new MyThing();
static readonly MyThing ThingValue = new MyThing();

protected override void ShouldThrowAWobbly()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Shouldly.Tests.Dictionaries.ShouldNotContainValueForKey
{
public class StringScenario : ShouldlyShouldTestScenario
{
private readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
{
{ "Foo", "Bar"}
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Shouldly.Tests.Dictionaries.ShouldNotContainValueForKey
{
public class StringScenario_KeyAndValueExist : ShouldlyShouldTestScenario
{
private readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
{
{ "Foo", "Bar"}
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Shouldly.Tests.Dictionaries.ShouldNotContainValueForKey
{
public class StringScenario_NoKeyExists : ShouldlyShouldTestScenario
{
private readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
readonly Dictionary<string, string> _dictionary = new Dictionary<string, string>
{
{ "Foo", "Bar"}
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ public class ValueIsNull : ShouldlyShouldTestScenario
{ThingKey, ThingValue}
};

private static readonly MyThing ThingKey = new MyThing();
private static readonly MyThing ThingValue = null;
static readonly MyThing ThingKey = new MyThing();
static readonly MyThing ThingValue = null;

protected override void ShouldThrowAWobbly()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,16 +141,16 @@ public void HighlightDifferencesBetween_BigList_ShowsLimitedNumberOfElements()
.ShouldBe("[*666*, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540, 541, 542, 543, 544, 545, 546, 547, 548, 549, 550, 551, 552, 553, 554, 555, 556, 557, 558, 559, 560, 561, 562, 563, 564, 565, 566, 567, 568, 569, 570, 571, 572, 573, 574, 575, 576, 577, 578, 579, 580, 581, 582, 583, 584, 585, 586, 587, 588, 589, 590, 591, 592, 593, 594, 595, 596, 597, 598, 599, 600, 601, 602, 603, 604, 605, 606, 607, 608, 609, 610, 611, 612, 613, 614, 615, 616, 617, 618, 619, 620, 621, 622, 623, 624, 625, 626, 627, 628, 629, 630, 631, 632, 633, 634, 635, 636, 637, 638, 639, 640, 641, 642, 643, 644, 645, 646, 647, 648, 649, 650, 651, 652, 653, 654, 655, 656, 657, 658, 659, 660, 661, 662, 663, 664, 665, 666, 667, 668, 669, 670, 671, 672, 673, 674, 675, 676, 677, 678, 679, 680, 681, 682, 683, 684, 685, 686, 687, 688, 689, 690, 691, 692, 693, 694, 695, 696, 697, 698, 699, 700, 701, 702, 703, 704, 705, 706, 707, 708, 709, 710, 711, 712, 713, 714, 715, 716, 717, 718, 719, 720, 721, 722, 723, 724, 725, 726, 727, 728, 729, 730, 731, 732, 733, 734, 735, 736, 737, 738, 739, 740, 741, 742, 743, 744, 745, 746, 747, 748, 749, 750, 751, 752, 753, 754, 755, 756, 757, 758, 759, 760, 761, 762, 763, 764, 765, 766, 767, 768, 769, 770, 771, 772, 773, 774, 775, 776, 777, 778, 779, 780, 781, 782, 783, 784, 785, 786, 787, 788, 789, 790, 791, 792, 793, 794, 795, 796, 797, 798, 799, 800, 801, 802, 803, 804, 805, 806, 807, 808, 809, 810, 811, 812, 813, 814, 815, 816, 817, 818, 819, 820, 821, 822, 823, 824, 825, 826, 827, 828, 829, 830, 831, 832, 833, 834, 835, 836, 837, 838, 839, 840, 841, 842, 843, 844, 845, 846, 847, 848, 849, 850, 851, 852, 853, 854, 855, 856, 857, 858, 859, 860, 861, 862, 863, 864, 865, 866, 867, 868, 869, 870, 871, 872, 873, 874, 875, 876, 877, 878, 879, 880, 881, 882, 883, 884, 885, 886, 887, 888, 889, 890, 891, 892, 893, 894, 895, 896, 897, 898, 899, 900, 901, 902, 903, 904, 905, 906, 907, 908, 909, 910, 911, 912, 913, 914, 915, 916, 917, 918, 919, 920, 921, 922, 923, 924, 925, 926, 927, 928, 929, 930, 931, 932, 933, 934, 935, 936, 937, 938, 939, 940, 941, 942, 943, 944, 945, 946, 947, 948, 949, 950, 951, 952, 953, 954, 955, 956, 957, 958, 959, 960, 961, 962, 963, 964, 965, 966, 967, 968, 969, 970, 971, 972, 973, 974, 975, 976, 977, 978, 979, 980, 981, 982, 983, 984, 985, 986, 987, 988, 989, 990, 991, 992, 993, 994, 995, 996, 997, 998, 999, ...]");
}

private enum Weapons
enum Weapons
{
Axe,
Chainsaw,
Screwdriver
}

private class EqualType
class EqualType
{
private readonly string _description;
readonly string _description;

public EqualType(string description)
{
Expand All @@ -173,9 +173,9 @@ public override int GetHashCode()
}
}

private class NonEqualType
class NonEqualType
{
private readonly string _description;
readonly string _description;

public NonEqualType(string description)
{
Expand All @@ -188,9 +188,9 @@ public override string ToString()
}
}

private class PureEnumerable : IEnumerable
class PureEnumerable : IEnumerable
{
private readonly List<int> _numbers = new List<int>();
readonly List<int> _numbers = new List<int>();

public void Add(int number)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ namespace Shouldly.Tests.InternalTests
[TestFixture]
public class DifferenceIndexConsolidatorTests
{
private const int MaxDiffLength = 5;
private const int MaxLengthOfStrings = 21;
const int MaxDiffLength = 5;
const int MaxLengthOfStrings = 21;

[Test, TestCaseSource("IndexConsolidationTestCases")]
public void ShouldConsolidate_Indices_Correctly_GivenInput(List<int> indicesOfAllDifferences, List<int> expectedConsolidatedOutputIndices)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace Shouldly.Tests.InternalTests
[TestFixture]
public class EnumerableHighlighterTests
{
private readonly EnumerableDifferenceHighlighter _highlighter = new EnumerableDifferenceHighlighter();
readonly EnumerableDifferenceHighlighter _highlighter = new EnumerableDifferenceHighlighter();

[Test]
public void CanProcessTwoEnumerables()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace Shouldly.Tests.InternalTests
[TestFixture]
public class StringDifferenceHighlighterTests
{
private readonly StringDifferenceHighlighter _highlighter = new StringDifferenceHighlighter();
readonly StringDifferenceHighlighter _highlighter = new StringDifferenceHighlighter();

[Test]
public void CanProcessTwoNotNullStringsAndAShouldBeAssertionMethod()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,13 @@ but was

Assert.AreEqual(expected, actual);
}
private class MockCodeTextGetter : ICodeTextGetter

class MockCodeTextGetter : ICodeTextGetter
{
public string GetCodeText() { return "SomeCodeText"; }
}
private class MockDiffHighlighter : IStringDifferenceHighlighter

class MockDiffHighlighter : IStringDifferenceHighlighter
{
public string HighlightDifferences(string expected, string actual)
{
Expand Down
1 change: 0 additions & 1 deletion src/Shouldly.Tests/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using System.Reflection;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;

// General Information about an assembly is controlled through the following
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ namespace Shouldly.Tests.ShouldBe.EnumerableType
{
public class EnumerableOfComplexTypeScenario : ShouldlyShouldTestScenario
{
private readonly IEnumerable<Widget> _aEnumerable = new Widget { Name = "Joe", Enabled = true }.ToEnumerable();
private readonly Widget[] _bArray = {new Widget {Name = "Joeyjojoshabadoo Jr", Enabled = true}};
readonly IEnumerable<Widget> _aEnumerable = new Widget { Name = "Joe", Enabled = true }.ToEnumerable();
readonly Widget[] _bArray = {new Widget {Name = "Joeyjojoshabadoo Jr", Enabled = true}};

protected override void ShouldThrowAWobbly()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ protected override string ChuckedAWobblyErrorMessage
}
}

private static IEnumerable<int> GetEmptyEnumerable()
static IEnumerable<int> GetEmptyEnumerable()
{
yield break;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ protected override string ChuckedAWobblyErrorMessage
}
}

private static IEnumerable<int> GetEnumerable()
static IEnumerable<int> GetEnumerable()
{
yield return 1;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ protected override string ChuckedAWobblyErrorMessage
}
}

private static IEnumerable<int> GetEmptyEnumerable()
static IEnumerable<int> GetEmptyEnumerable()
{
yield break;
}
Expand Down

0 comments on commit 7b8f15b

Please sign in to comment.