Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jnm2 nullable reference types #634

Merged
merged 56 commits into from
Jul 6, 2020
Merged

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Jul 6, 2020

replaces #581

Closes #579.

jnm2 and others added 30 commits December 13, 2019 09:07
@SimonCropp SimonCropp added this to the 4.0.0 milestone Jul 6, 2020
@SimonCropp SimonCropp merged commit 11e1400 into master Jul 6, 2020
@SimonCropp SimonCropp deleted the jnm2-nullable_reference_types branch July 6, 2020 07:16
@jnm2
Copy link
Collaborator

jnm2 commented Jul 7, 2020

This was a squash merge 😢 I can't fetch these commits and look through them locally.

@SimonCropp
Copy link
Contributor Author

@jnm2 sorry about the hassle. you should be able to delete you master and re-pull this master. or delete and re-fork

@jnm2
Copy link
Collaborator

jnm2 commented Jul 7, 2020

It's okay. It's not that, it's that the commits in this PR don't exist in the upstream master branch (or the entire upstream repo). Only a squash commit exists. I can't tell what part was me and what part was your changes. It'll be fine!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide annotations for C# 8 Nullable Reference Types
2 participants