Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension example in the README #63

Closed
wants to merge 2 commits into from
Closed

Conversation

@nilbus
Copy link

nilbus commented Jul 6, 2013

var converter = new Showdown.converter({ extensions: 'twitter' });

Since it loops over the value of options.extensions, it ends up looping over each character in the string twitter ['t', 'w', 'i', ...] and fails to load the extension.

nilbus added 2 commits Jul 6, 2013
    var converter = new Showdown.converter({ extensions: 'twitter' });

Since it loops over the value of options.extensions, it ends up looping over each character in the string twitter ['t', 'w', 'i', ...] and fails to load the extension.
A filter language extension needs the filter key, or it's not valid javascript syntax.
@thejspr
Copy link

thejspr commented Jul 7, 2013

👍

@nilbus
Copy link
Author

nilbus commented Jul 8, 2013

This duplicates #47, #54. Both of those should be merged.

@coreyti if you don't have time and would like some help resolving the open issues, I would be glad to assist. Just let me know.

@nilbus nilbus closed this Jul 8, 2013
@nilbus nilbus deleted the nilbus:patch-1 branch Jul 8, 2013
@nilbus nilbus restored the nilbus:patch-1 branch Jul 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.