Use nightwatch.js for functional tests #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shvaikalesh
commented
Jan 17, 2017
| module.exports = { | ||
| before: done => { | ||
| chromedriver.start(); | ||
| done(); |
There was a problem hiding this comment.
done() should always be called.
shvaikalesh
commented
Jan 17, 2017
|
|
||
| 'changes slides states when moving backward': browser => { | ||
| browser.url(`file:///${__dirname}/list.html#3`); | ||
| browser.keys(browser.Keys.ARROW_LEFT); |
There was a problem hiding this comment.
Nightwatch's constants for key codes are cool.
shvaikalesh
commented
Jan 17, 2017
| @@ -0,0 +1,16 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Several tests had
- open
list - go
full - really test stuff
algorithms in keys/tests.js. With addition of this file, they are greatly simplified.
|
(Shift) F5 key has dropped in 2f0af4d so test could be dropped as well, otherwise WFM locally and LGTM in general. |
pepelsbey
force-pushed
the
use-nightwatch
branch
from
c173e0e
to
f488710
Compare
|
I've also added tests for a1567ac |
|
There are still some wdio dependencies left: Do we still need Could you please clean up? |
|
Oops, my bad. Please, see #123. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each test case happen in separate process (Chrome gets restarted every time). If
browser.end()is dropped, random tests start to fail. It takes 50sec on my machine to run them all. Please, let me know if we should find a way around this and whether I should prioritize this.