Enable fullscreen in slide mode

[wichert]

We are looking at enabling the browser's fullscreen mode if supported when entering slide mode. The attached changes are a first cut at doing this. This probably warrants more testing and discussion if this should be enabled by default or a configurable option.

[pepelsbey]

There's definitely should be a way to see slides in presentation mode in normal browser window as currently there are four available modes: list and full in browser window, list and full in fullscreen mode. In your case there will be only two modes: window list and fullscreen full — which is less flexible, I guess.

And on code style: using curly brackets for if…else makes code more readable and predictable. Am I right @miripiruni?

[ai]

@pepelsbey we think to use Shower in our Brainwashing Rails cources, but we require fullscreen support.

I can help with JS, what is current status and what refactoring is needed?

[wichert]

For what it's worth we ended up writing our own slideshow library which supports fullscreen as well as a separate presenter console. You can find the code in the slides repository.

[ai]

@wichert ugly default styles in slides, I prefer Shower ;).

[wichert]

Styling is up to personal taste, and default CSS is there to customise. It should be trivial to adapt Shower’s CSS to work with slides since they have very similar markup structure if you want to.

[ai]

@wichert I prefer to add fullscreen in Shower, rather styling another framework.

Problem in Slides is not about taste, but about common design rules. I can not trust in slides engine, which doesn‘t respect design.

[wichert]

@ai This is getting incredibly off-topic for this ticket, but can you tell me where you feel Slides is not following common design rules? I'm nor aware of any rules being violated, but if there are I would like to fix that.

[tonyganch]

@ai, «but we require fullscreen support» — how will this differ from ^⌘F, for example?

[ai]

@tonyganch my Chrome go to fullscreen without hiding tabs and address bar :-(. I use Create Web App to run presentation in shromeless mode.

[tonyganch]

@ai, ⇧⌘F?

[ai]

@tonyganch there is no Presentation Mode on Linux and Windows :(.

[pepelsbey]

Wait a second! There's F11 button on Windows that triggers full screen mode perfectly in Opera, Chrome, Firefox and IE. No tabs, no menus, just a plain and perfect full screen.

Still not sure about Linux, @ai could you please check?

[pepelsbey]

I'm about to close this pull request and all fullscreen-related issues as there's built-in functionality freely available in browsers.

[ai]

BY some reason, when I press F11, my Chrome still show me tabs and adress bar (Linux, Chrome 33).

[pepelsbey]

Works fine in Chrome for Windows. Should it be just a “Linux feature” then? :\

[ai]

I try to find more. Maybe it is fullscreen bug only in my environment.

[pepelsbey]

You can switch to a proper fullscreen mode without toolbars in following browsers

• Mac: Chrome, Opera, Yandex.Browser (all Chromium-based, using Cmd Shift F)
• Windows: IE, Firefox, Opera, Chrome, Yandex.Browser (using F11)

There’s no proper fullscreen mode in following browsers:

• Mac: Firefox, Safari (tabs are visible)

Is it worth to bind proper fullscreen on F key (or any other shortcut) only for Firefox and Safari on Mac? /cc @miripiruni @tonyganch @ai

[ai]

I will be happy with shower.fullscreen().

[pepelsbey]

@ai, you mean just a console method without shortcut?

[ai]

Yeap. I often had a lot of JS and CSS on top of shower in our slides, so I can easy bind F key in my code :).