Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added information about spotlight element #369

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Added information about spotlight element #369

merged 1 commit into from
Mar 2, 2021

Conversation

AntonShevchuk
Copy link
Contributor

Was ordered elements by alphabet in the Elements section.
Also fixed some small mistakes.

Was ordered elements by alphabet in the Elements section.
Also fixed some small mistakes.
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d rather add all the cool custom demos to the actual slides to keep the docs as simple as possible. These docs are pretty outdated and doesn’t really cover all the modern features. It doesn’t look good when some basic features are missing but one feature is full of miracles.

@AntonShevchuk
Copy link
Contributor Author

It can be the first step :)
Or migrate it to wiki pages.

@pepelsbey pepelsbey merged commit 982a04b into shower:master Mar 2, 2021
@pepelsbey
Copy link
Member

Thank you! I’ll spend some time to improve the docs, but I’d like to keep in readme, wiki pages are too much detached from the code.

@AntonShevchuk AntonShevchuk deleted the patch-2 branch March 3, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants