Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing rule params in Snakefile doesn't trigger re-run of rule #199

Closed
rodluger opened this issue Sep 22, 2022 · 2 comments · Fixed by #217 or #221
Closed

Changing rule params in Snakefile doesn't trigger re-run of rule #199

rodluger opened this issue Sep 22, 2022 · 2 comments · Fixed by #217 or #221
Labels
🐛 bug Something isn't working

Comments

@rodluger
Copy link
Collaborator

I need to look into this -- currently users must touch the actual script that runs the rule for it to be re-run, which is not optimal!

@rodluger
Copy link
Collaborator Author

This seems to be by design on the Snakemake side. Their docs say you can force a re-run of rules with params changes as follows:

snakemake -R `snakemake --list-params-changes`

I suggest we make that the default behavior when calling showyourwork.

@rodluger
Copy link
Collaborator Author

Actually it looks like this behavior changed in Snakemake as of version 7.8: it now does what we want! However, we're pinned at version 6.15.5, and upgrading may or may not break things because of all the hacks we've implemented to enable various showyourwork features. So our choices are -- upgrade the pinned version (and deal with potential breaking changes) or keep it at the current Snakemake version and implement the new functionality of Snakemake on the showyourwork side.

@rodluger rodluger added the 🐛 bug Something isn't working label Sep 23, 2022
@rodluger rodluger linked a pull request Oct 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
1 participant