Skip to content

Commit

Permalink
vfs: allow O_PATH file descriptors for fstatfs()
Browse files Browse the repository at this point in the history
commit 9d05746 upstream.

Olga reported that file descriptors opened with O_PATH do not work with
fstatfs(), found during further development of ksh93's thread support.

There is no reason to not allow O_PATH file descriptors here (fstatfs is
very much a path operation), so use "fdget_raw()".  See commit
55815f7 ("vfs: make O_PATH file descriptors usable for 'fstat()'")
for a very similar issue reported for fstat() by the same team.

Reported-and-tested-by: ольга крыжановская <olga.kryzhanovska@gmail.com>
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
torvalds authored and gregkh committed Oct 22, 2013
1 parent c2f2710 commit 5187f53
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/statfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ int user_statfs(const char __user *pathname, struct kstatfs *st)

int fd_statfs(int fd, struct kstatfs *st)
{
struct file *file = fget(fd);
struct file *file = fget_raw(fd);
int error = -EBADF;
if (file) {
error = vfs_statfs(&file->f_path, st);
Expand Down

0 comments on commit 5187f53

Please sign in to comment.