Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial formal platform support #4

Merged
merged 24 commits into from
May 18, 2024
Merged

Initial formal platform support #4

merged 24 commits into from
May 18, 2024

Conversation

lethalbit
Copy link

This PR adds initial platform support and modifications needed for integrated formal verification within Torii.

@lethalbit lethalbit force-pushed the aki/formal branch 3 times, most recently from 7b9ebbc to 4f2d805 Compare March 14, 2024 08:27
Copy link

codecov bot commented Mar 14, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to us - just a couple of items of feedback/queries and with those taken care of, this looks like it should be good to merge. Nice work!

torii/hdl/ir.py Outdated Show resolved Hide resolved
torii/platform/formal.py Outdated Show resolved Hide resolved
Copy link

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for merge once the CI completes.

@dragonmux dragonmux merged commit 783edd2 into main May 18, 2024
10 of 11 checks passed
@lethalbit lethalbit deleted the aki/formal branch May 18, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants