SHRINKRES-215 Fixed putIfAbsent usage

shrinkwrap · Mar 13, 2015 · 5ff762e · 5ff762e
1 parent 9395693
commit 5ff762e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/api-maven/src/main/java/org/jboss/shrinkwrap/resolver/api/maven/PackagingType.java b/api-maven/src/main/java/org/jboss/shrinkwrap/resolver/api/maven/PackagingType.java
@@ -109,7 +109,11 @@ public static PackagingType of(String typeName) throws IllegalArgumentException
             throw new IllegalArgumentException("Packaging type must not be null nor empty.");
         }
         // return from cache if available
-        return cache.putIfAbsent(typeName, new PackagingType(typeName));
+        if(cache.containsKey(typeName)) {
+            return cache.get(typeName);
+        }
+        // this will cause packaging object to register into cache
+        return new PackagingType(typeName);
     }
 
     // we are using only id for hashCode() and equals(Object)

diff --git a/api-maven/src/test/java/org/jboss/shrinkwrap/resolver/api/maven/PackagingTypeTestCase.java b/api-maven/src/test/java/org/jboss/shrinkwrap/resolver/api/maven/PackagingTypeTestCase.java
@@ -67,4 +67,9 @@ public void par() {
         Assert.assertEquals("par", PackagingType.PAR.toString());
     }
 
+    @Test
+    public void random() {
+        Assert.assertEquals("random", PackagingType.of("random").toString());
+    }
+
 }