Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password prottected maven reposistory support for shrinkwrap maven resolver #10

Closed
wants to merge 2 commits into from

Conversation

sacdroid
Copy link
Contributor

No description provided.

@kpiwko
Copy link
Member

kpiwko commented Oct 24, 2011

Hi Sachin, many thanks for the pull request. However, can you please fill a JIRA at https://issues.jboss.org/browse/SHRINKWRAP/component/12313482 first so we can track which features/bug-fixes were added to a particular version?

Karel

@sacdroid
Copy link
Contributor Author

Hi Karel,

I have already create issue at https://issues.jboss.org/browse/SHRINKWRAP-345 for impl-base module. Do you want me to move it to ext-resolver?

Thanks,

-- Sachn

@sacdroid sacdroid closed this Oct 24, 2011
@sacdroid sacdroid reopened this Oct 24, 2011
@kpiwko
Copy link
Member

kpiwko commented Oct 24, 2011

Sachn,

I updated the jira. Have you already signed CLA so I can pick up your patch marking you as an author https://cla.jboss.org?

I expect this won't be included in 1.1 branch, but in 2.0.0 branch, we are currently developing, so a rebase against https://github.com/kpiwko/resolver/tree/api-changes would be needed there.

@kpiwko
Copy link
Member

kpiwko commented Oct 24, 2011

Note, your change will go to MavenEnvironmentImpl class

@sacdroid
Copy link
Contributor Author

Yes, I signed into cla.jboss.org and new pull request for api-changes branch is here kpiwko#1

@sacdroid sacdroid closed this Oct 24, 2011
@sacdroid sacdroid reopened this Oct 24, 2011
@kpiwko
Copy link
Member

kpiwko commented Oct 29, 2011

Pushed into api-changes branch, will be a part of 2.0.0

@kpiwko kpiwko closed this Oct 29, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants