Use Plexus container to grab Maven components #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As one of the reasons to container is exactly to protect you (client code) for breakage that is not gonna happen with components, as instantiation is done by container. This code is now fully compatible with ALL line of Maven versions released so far (from lowest that shrinkwrap resolver requires of course).
To not cope with archaic Plexus API. Still, using Plexus API may be more suitable, by providing internal methods that hide checked exceptions like 1st commit did, as those checked exceptions should actually be unchecked, as they are terminal).
|
2nd commit:
|
but wrap it up. Added some examples as well.
|
3rd commit undos change to Injector, is cleaner this way (and keeps Guice as runtime dep). Added some showcase examples as well. |
|
@cstamas thanks for submitting the PR. I see it's still a draft, is there more work to be done to fix this issue? |
|
In the meantime https://github.com/maveniverse/mima was born, so this PR is to be replaced with MIMA one, will do that once home |
|
Plexus DI is EOL anyway, not recommended to move to something that is dead/unmaintained already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As one of the reasons to container is exactly to protect
you (client code) for breakage that is not gonna happen
with components, as instantiation is done by container.
This code is now fully compatible with ALL line of Maven
versions released so far (from lowest that shrinkwrap
resolver requires of course). -- this stands for currently known issues like https://issues.apache.org/jira/projects/MNG/issues/MNG-7475 but naturally there may be more breakages.