Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHRINKRES-91 #27

Merged
merged 0 commits into from
Dec 10, 2012
Merged

SHRINKRES-91 #27

merged 0 commits into from
Dec 10, 2012

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Dec 3, 2012

This reverts commit a72cfa9.

@ALRubinger
Copy link
Member

Why are we reverting?

@ALRubinger
Copy link
Member

Karel's explanations in https://issues.jboss.org/browse/SHRINKRES-91

@gastaldi gastaldi merged commit 5c43166 into shrinkwrap:master Dec 10, 2012
@ALRubinger
Copy link
Member

Confused:

  1. George, how did you merge something into upstream?
  2. Please leave closing Pull Requests to the Project Lead, just so we can unify Administrative tasks (at the moment, that's Karel or me for Resovlers)
  3. I don't see any 5c43166 merged in upstream/master ?

@gastaldi
Copy link
Contributor Author

Hey Andrew,

Actually I sync'ed the official repository with my forked master, which removed the commit I from this pull request. GitHub automatically closes pull requests when this happen

@gastaldi
Copy link
Contributor Author

Looks like this is a Github issue. The message is wrong since I didn't pushed anything to shrinkwrap:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gastaldi @ALRubinger