Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deps + scope test. #33

Closed
wants to merge 1 commit into from
Closed

Add deps + scope test. #33

wants to merge 1 commit into from

Conversation

alesj
Copy link
Contributor

@alesj alesj commented Dec 20, 2012

No description provided.

@ALRubinger
Copy link
Member

What I'm understanding from this test case:

Ales would like to "filter" out dependencies by scopes, but in the example shown, jboss-logging is not resolved as a dependency from XNIO because the XNIO POM puts it in "provided" scope. Therefore there's nothing to filter out, and the test fails. Is that a correct summation? My branch has a modified version of this test which eliminates the reliance on system properties and uses the standard settings.xml we package with the SWR tests.

ALRubinger@91316f7

If this description above is correct, please let me know so I can open an appropriate JIRA. Sorry it took a bit to decode what you're looking for here.

@ALRubinger
Copy link
Member

Reference: XNIO POM in question which Ales would like to pull in jboss-logging: http://search.maven.org/remotecontent?filepath=org/jboss/xnio/xnio-api/3.1.0.Beta7/xnio-api-3.1.0.Beta7.pom

@alesj
Copy link
Contributor Author

alesj commented Jan 7, 2013

Well, we coould actually say un-filter then. :-)
Anyway, as long as you make my test pass, I'm fine. ;-)

@kpiwko
Copy link
Member

kpiwko commented Jan 7, 2013

I think this is a valid use case. If we say strategy, we do not distinguish filtering and un-filtering. Strategy should allow you to say what you want, whereas filter will reduce results that Maven resolves by default. There is no "maven resolved by default" for strategies.

@ALRubinger
Copy link
Member

Agreed. So wondering aloud as I play with the impl how we get Aether to
resolve "provided" deps. Unless Karel knows off the top of his head?

@ALRubinger
Copy link
Member

Found the magic sauce in Aether, and added some API love to give us hooks.

Upstream: ALRubinger@af3a87e and ALRubinger@6e125ce.

@ALRubinger ALRubinger closed this Jan 16, 2013
@ALRubinger
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants