SHRINKWRAP-288 - added loading file from stream in jar #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classpath.Now I completed the feature adding the possibiltiy to load a file from inside a jar.
| @@ -125,23 +130,16 @@ public class MavenBuilderImpl implements MavenDependencyResolverInternal | |||
| @Override | |||
| public MavenDependencyResolver configureFrom(String path) | |||
| { | |||
| path = resolvePathByQualifier(path); | |||
| Validate.isReadable(path, "Path to the settings.xml ('" + path + "')must be defined and accessible"); | |||
There was a problem hiding this comment.
This clutters the real path user specified, making the exception message unclear.
There was a problem hiding this comment.
Actually, you're right, specially if the path is resolved for "classpath".
we can attribute the resolvedPath to a new String. wdyt?
|
Pushed upstream as SHRINKWRAP-323. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added before the possibility to add a file in classpath.Now I completed the feature adding the possibiltiy to load a file from inside a jar.