Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHRINKRES-213 Add support for ResolvedArtifact.as(URL.class) #79

Merged
merged 1 commit into from Nov 7, 2014
Merged

SHRINKRES-213 Add support for ResolvedArtifact.as(URL.class) #79

merged 1 commit into from Nov 7, 2014

Conversation

aslakknutsen
Copy link
Member

No description provided.

@aslakknutsen
Copy link
Member Author

Not sure if we should add ResolvedArtifact.asURL|asSingleURL to be coherent API wise with the other 'resolver-spi' FormatProcessor's?

@kpiwko kpiwko merged commit d8afdd8 into shrinkwrap:master Nov 7, 2014
@kpiwko
Copy link
Member

kpiwko commented Nov 11, 2014

I don't think this is such often used formatting to be worth it to be honest. Having just as(URL.class) seems fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@aslakknutsen @kpiwko