[SHRINKWRAP-290] Check for resource existence

impl-base/src/main/java/org/jboss/shrinkwrap/impl/base/container/ContainerBase.java

@@ -1504,10 +1504,19 @@ protected Class<T> getActualClass()
       return this.actualType;
    }
 
-   private File fileFromResource(final String resourceName)
+   /**
+    * Gets a resource from the TCCL and returns its file path.
+    * 
+    * @param resourceName is the name of the resource in the classpath
+    * @return the file path for resourceName @see {@link java.net.URL#getFile()}
+    * @throws IllegalArgumentException if resourceName doesn't exist in the classpath or privileges are not granted
+    */
+   private File fileFromResource(final String resourceName) throws IllegalArgumentException
    {
-      final String resourcePath = AccessController.doPrivileged(GetTcclAction.INSTANCE).getResource(resourceName)
-            .getFile();
+      final URL resourceUrl = AccessController.doPrivileged(GetTcclAction.INSTANCE).getResource(resourceName);
+      Validate.notNull(resourceUrl, resourceName + " doesn't exist or can't be accessed");
+
+      final String resourcePath = resourceUrl.getFile();
       return new File(resourcePath);
    }
 

impl-base/src/test/java/org/jboss/shrinkwrap/impl/base/test/DynamicContainerTestBase.java

@@ -196,6 +196,15 @@ public void testAddManifestResource() throws Exception {
             "Archive should contain " + testPath,
             getArchive().contains(testPath));
    }
+
+   @Test(expected = IllegalArgumentException.class)
+   @ArchiveType(ManifestContainer.class)
+   public void testAddNonExistentManifestResource() throws Exception {
+      final String nonExistentResourceName = "ejb/security/ejb-jar.xml";
+
+      //Since the resource doesn't exist the ManifestContainer implementation throws the expected exception
+      getManifestContainer().addAsManifestResource(nonExistentResourceName);
+   }
 
    @Test
    @ArchiveType(ManifestContainer.class)