Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHRINKWRAP-294 Rewritten settings.xml holder internals #26

Closed
wants to merge 2 commits into from

Conversation

kpiwko
Copy link
Member

@kpiwko kpiwko commented Jun 30, 2011

  • Rewritten and removed MavenRepositorySettings, added
    ** MavenDependencyResolverSettings - settings for resolver and Maven
    settings
    ** MavenSettingsBuilder - a convinient class to parse settings.xml
    ** MavenManagerBuilder - listener/manager/mirror-selector creator
  • Added licence headers to most of the files
  • Minor doc updates
  • Added possibility to go offline in resolution
  • Honors mirror settings from settings.xml

* Rewritten and removed MavenRepositorySettings, added
** MavenDependencyResolverSettings - settings for resolver and Maven
settings
** MavenSettingsBuilder - a convinient class to parse settings.xml
** MavenManagerBuilder - listener/manager/mirror-selector creator
* Added licence headers to most of the files
* Minor doc updates
* Added possibility to go offline in resolution
* Honors mirror settings from settings.xml
@tommysdk
Copy link

tommysdk commented Jul 7, 2011

I think it looks very good, impressive work!

@ALRubinger
Copy link
Member

I'm going to push what we have, because it's good. But keeping this pull request open until we resolve why the @OverRide annotations have gone away?

@ALRubinger
Copy link
Member

Upstream: 918d628

Pending @OverRide review before close

@kpiwko
Copy link
Member Author

kpiwko commented Jul 12, 2011

Hi Andrew,

@OverRide annotation were removed as they were JDK 6 specific (@OverRide on a method implemented from an interface won't compile on JDK5). I forgot to mention that in detailed commit message.

@ALRubinger
Copy link
Member

We compile on JDK6, set target to JRE5-compat. So that's fine. :) Would you put 'em back?

@kpiwko
Copy link
Member Author

kpiwko commented Jul 12, 2011

Yep, I will put them back.

@kpiwko
Copy link
Member Author

kpiwko commented Jul 13, 2011

Andrew, @OverRide annotations are back. Please note that I used custom save action in Eclipse, resulting in more @OverRide annotations we had before ;). Now all methods that implement an interface in shrinkwrap-extension-resolver are annotated with an @OverRide annotation.

@ALRubinger
Copy link
Member

Done-zo: ef87c99

@ALRubinger ALRubinger closed this Jul 13, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants