[SHRINKWRAP-336] Provide addAsServiceProvider overload that supports String #47

Open
wants to merge 1 commit into
from

Projects

None yet

1 participant

Contributor
DavideD commented Dec 15, 2011

I hope is correct.

Cheers

@DavideD DavideD commented on the diff Dec 15, 2011
.../shrinkwrap/impl/base/asset/ServiceProviderAsset.java
@@ -53,8 +72,8 @@ public ServiceProviderAsset(Class<?>... providerImpls) {
@Override
public InputStream openStream() {
StringBuilder content = new StringBuilder();
- for (Class<?> providerImpl : providerImpls) {
- content.append(providerImpl.getName()).append('\n');
+ for (String providerImpl : providerImpls) {
+ content.append(providerImpl).append('\n');
DavideD
DavideD Dec 15, 2011 Contributor

Shuoldn't be used System.getProperty("line.separator") instead of '\n'?

Contributor
DavideD commented Dec 21, 2011

Shame on me

Is this solution better? I've moved the getServiceProvidersPath method from WebContainerBase to ContainerBase so that I now have a method for the location of the services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment