Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate pinning removal not working under Windows #27

Closed
shroudedcode opened this issue Dec 14, 2020 · 0 comments
Closed

Certificate pinning removal not working under Windows #27

shroudedcode opened this issue Dec 14, 2020 · 0 comments
Labels
bug Something isn't working certificate pinning Issues related to certificate pinning windows Issues specific to Windows

Comments

@shroudedcode
Copy link
Owner

Please take a look at different result on Windows with same apk file.

apk-mitm Windows vs Linux

There are two issues with current apk-mitm running in Windows.

  1. Glob pattern only support posix path i.e forward-slashes which is different from Windows path conventions, therefore it won't be able to find any .smali files in the directory.

const smaliFiles = await globby(path.join(directoryPath, 'smali*/**/*.smali'))

  1. METHOD_PATTERNS is derived from regex which matches Linux's new line character LF but if you decode an apk on Windows, it will have CRLF as new line character so the regex won't be able to find the match of method signatures.

Originally posted by @amsharma44 in APKLab/APKLab#37 (comment)

@shroudedcode shroudedcode added the bug Something isn't working label Dec 14, 2020
@shroudedcode shroudedcode changed the title Certificate pinning removal not working under windows Certificate pinning removal not working under Windows Dec 14, 2020
@shroudedcode shroudedcode added certificate pinning Issues related to certificate pinning windows Issues specific to Windows labels Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working certificate pinning Issues related to certificate pinning windows Issues specific to Windows
Projects
None yet
Development

No branches or pull requests

1 participant