Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling certificate pinning → contents.matchAll is not a function #43

Closed
tropicyou opened this issue Mar 9, 2021 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@tropicyou
Copy link

tropicyou commented Mar 9, 2021

  ╭ apk-mitm v0.11.1
  ├ apktool v2.5.0
  ╰ uber-apk-signer v1.2.1
  
  Using temporary directory:
  /tmp/apk-mitm-de00bd5101216addae0234f5e2d63d22

  ✔ Downloading tools
  ✔ Decoding APK file
  ❯ Applying patches
    ✔ Modifying app manifest
    ✔ Replacing network security config
    ✖ Disabling certificate pinning
      → contents.matchAll is not a function
    Encoding patched APK file
    Signing patched APK file

   Failed!  An error occurred:

TypeError: contents.matchAll is not a function
    at Object.parseSmaliHead [as default] (/usr/local/lib/node_modules/apk-mitm/dist/tasks/smali/parse-head.js:14:41)
    at Object.processSmaliFile [as default] (/usr/local/lib/node_modules/apk-mitm/dist/tasks/smali/process-file.js:20:43)

  The full logs of all commands are available here:
  /tmp/apk-mitm-de00bd5101216addae0234f5e2d63d22/logs
@williamtran29
Copy link

yeah, I have the same issue

@shroudedcode
Copy link
Owner

This is what happens when you fix an issue, but don't release a new version with it. 😅
Anyway, a new version with the fix is out now. Updating to that should get rid of the error.

By the way: This issue only happened under Node.js 10 (which I'm only still supporting because I didn't do a major release yet). Node.js 10 will stop receiving security patches next month, so I generally recommend updating to Node.js 14.

@shroudedcode shroudedcode added the bug Something isn't working label Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants