Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck on "disabling certificate pinning" #9

Closed
KJL777 opened this issue Nov 17, 2019 · 6 comments
Closed

Stuck on "disabling certificate pinning" #9

KJL777 opened this issue Nov 17, 2019 · 6 comments

Comments

@KJL777
Copy link

KJL777 commented Nov 17, 2019

Hey! Appreciate all your hard work making this tool. Just a quick question regarding an issue I am experiencing. I've tried a few different apks and always hang on "disabling certificate pinning". The process never completes. I am wondering whether it is just the particular apks, or something on my end.

Thanks very much.

issue

@shroudedcode
Copy link
Owner

shroudedcode commented Nov 17, 2019

It seems like you're stuck on this line of code:

const smaliFiles = await globby(path.join(directoryPath, '**/*.smali'))

Looks like globby is taking forever to find all the files ending in *.smali.

You could try running globby manually to see if that also takes forever. To do that, open a terminal inside the temporary directory (logged at the top) and run:

npx globby-cli 'decode/**/*.smali'

@KJL777
Copy link
Author

KJL777 commented Nov 18, 2019

Thank you for the reply. Hmm, it must be a careless issue on my end. No luck with the above suggestion. Unsure of what I am doing incorrectly.

issue2

@shroudedcode
Copy link
Owner

I just realized that cmd doesn't interpret strings in single quotes the same way bash does, so please try running the command again with double quotes:

npx globby-cli "decode/**/*.smali"

@KJL777
Copy link
Author

KJL777 commented Nov 18, 2019

small app

I was able to have some success trying globby manually, but this only worked on a small sized apk (calculator) that I tried. Two other large game apks yield the same result as in the previous screenshot.

Also, despite globby working manually with the calculator app, it still hangs while attempting to locate smali files (removing pinning) using your tool.

@KJL777
Copy link
Author

KJL777 commented Nov 19, 2019

Friend of mine was able to get things working on his machine, thanks for the assistance.

@KJL777 KJL777 closed this as completed Nov 19, 2019
@dheeraj-rn
Copy link

@KJL777 Can you tell us how he did it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants