Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hook declaration #431

Merged
merged 2 commits into from Jan 15, 2022

Conversation

adamchainz
Copy link
Contributor

Fixes #429.

Copy link
Owner

@shssoichiro shssoichiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I appreciate this a lot, as my attention has been split between a lot of different projects lately.

@adamchainz
Copy link
Contributor Author

👍

I have no idea why the tests are failing, it's not because of this change is it?

FYI I tested this on a repo with many (already optimized) PNG files like so:

$ pre-commit try-repo ~/Documents/Projects/oxipng --all-files
[INFO] Initializing environment for ../oxipng.
===============================================================================
Using config:
===============================================================================
repos:
-   repo: ../oxipng
    rev: 961c1548ec6daeed1edc841c0a41323ffa81e80d
    hooks:
    -   id: oxipng
===============================================================================
[INFO] Installing environment for ../oxipng.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
oxipng...................................................................Passed

@shssoichiro
Copy link
Owner

It looks like I need to bump the minimum Rust version, because one of the dependencies bumped theirs.

I'll do that, and then you can rebase and it should work.

@shssoichiro shssoichiro merged commit acdd66b into shssoichiro:master Jan 15, 2022
@adamchainz adamchainz deleted the pre_commit branch January 15, 2022 11:10
@adamchainz
Copy link
Contributor Author

Huzzah! Thank you. Tested and working great.

FYI to make this discoverable, I've submitted the hook to be displayed on the pre-commit site (pre-commit/pre-commit.com#617) and added a note to my mirror (https://github.com/adamchainz/pre-commit-oxipng#deprecated-2022-01-15).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit integration
2 participants