[GSoC19] Rc articles tests and improvements #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reset git
add collaboration in setting and post add minor changes add collaboration toggle try collaborate in edit mode minor changes check setting while collaborating fix pseudo collision issue on collaboration
remove invite model
shubhsherl
changed the title
unclebean
reviewed
Jul 19, 2019
| setRcTitle(rcTitle) { | ||
| // Grab the post and current stored twitter title | ||
| let post = this.post; | ||
| let currentTitle = post.get('rcTitle'); |
There was a problem hiding this comment.
seems post & currentTitle are not mutable, we can use const.
unclebean
reviewed
Jul 19, 2019
| } | ||
| this.rcServices.getRoom(newRoom) | ||
| .then((room) => { | ||
| const existingRCRoom = room.data[0].exist && room.data[0].roomname === newRoom; |
There was a problem hiding this comment.
as we mentioned in another pull request, please use es6 destructuring feature.
unclebean
reviewed
Jul 19, 2019
| clearRcImage() { | ||
| this.set('post.rcImage', ''); | ||
|
|
||
| if (this.get('post.isNew')) { |
There was a problem hiding this comment.
can we extract all
if (this.get('post.isNew')) {
return;
}
to a util method, we should not duplicate it.
unclebean
reviewed
Jul 19, 2019
app/controllers/staff/index.js
Outdated
| if (role === 'Contributors') { | ||
| isParent = this.currentUser.get('id') === user.parentId && user.roles.get('firstObject').name === 'Contributor'; | ||
| } | ||
| return user.status === 'inactive' && (role ? isParent || user.roles.get('firstObject').name === role : true); |
There was a problem hiding this comment.
In activeUsers & suspendedUsers has duplicate logic, please think to build common method.
let isParent = false;
if (role === 'Contributors') {
isParent = this.currentUser.get('id') === user.parentId && user.roles.get('firstObject').name === 'Contributor';
}
return user.status === 'inactive' && (role ? isParent || user.roles.get('firstObject').name === role : true);
unclebean
reviewed
Jul 19, 2019
app/models/post.js
Outdated
| return new RSVP.Promise((resolve) => { | ||
| if (this.get('settings.isComments') && this.isPublished && !this.discussionRoomId && this.displayName === 'post') { | ||
| return this.rcServices.createDiscussion(this.title, this.discussionRoomType).then((room) => { | ||
| if (room && room.data[0].created) { |
There was a problem hiding this comment.
can destructing value like [{create, rid, roomname, type}] = room.data;
|
@unclebean updated with changes as requested. |
|
@shubhsherl well done |
unclebean
approved these changes
Jul 23, 2019
unclebean
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
06f3145
78bc602
59df658