Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loader should reuse the page map in production build #34

Closed
shuding opened this issue Dec 6, 2020 · 0 comments
Closed

Loader should reuse the page map in production build #34

shuding opened this issue Dec 6, 2020 · 0 comments

Comments

@shuding
Copy link
Owner

shuding commented Dec 6, 2020

It’s fine to watch all, access fs and trigger updates in dev environment. But for production build (NODE_ENV=production) we should reuse the page map.

This ensures prod build is O(n) instead of O(n^2).
@shuding shuding mentioned this issue Dec 17, 2020
Closed
promer94 added a commit to promer94/nextra that referenced this issue Jan 1, 2022
@promer94
refactor: improve core
0e635ff 
1. refactor remark plugin for header
2. add some basic test using vitest
3. cache pagemap close shuding#34
@promer94 promer94 mentioned this issue Jan 1, 2022
Merged
promer94 added a commit to promer94/nextra that referenced this issue Jan 14, 2022
@promer94
improve core
4a3c044 
1. refactor remark plugin for header
2. add some basic test using vitest
3. cache pagemap close shuding#34
@shuding shuding closed this as completed Jan 15, 2022
tatukoivisto pushed a commit to tatukoivisto/nextra that referenced this issue Aug 20, 2023
@promer94
improve core
1f7827b 
1. refactor remark plugin for header
2. add some basic test using vitest
3. cache pagemap close shuding#34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shuding