Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nextra): ignore in loader files from pages/api folder #543

Merged
merged 4 commits into from Jul 22, 2022
Merged

fix(nextra): ignore in loader files from pages/api folder #543

merged 4 commits into from Jul 22, 2022

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Jul 15, 2022 •
edited

fixes #542
ignore but print warning
image

Update: Or maybe we should throw but with a friendly error? and not with TypeError

@vercel
Copy link

vercel bot commented Jul 15, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextra-theme-docs-dev ✅ Ready (Inspect) Visit Preview Jul 22, 2022 at 7:37AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
nextra ⬜️ Ignored (Inspect) Jul 22, 2022 at 7:37AM (UTC)

@dimaMachina dimaMachina changed the title fix(nextra): ignore loading markdown files in pages/api folder fix(nextra): ignore in loader files from pages/api folder Jul 15, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2022 •
edited

🦋 Changeset detected

Latest commit: 958882c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shuding shuding closed this Jul 22, 2022
@shuding shuding reopened this Jul 22, 2022
@shuding
Copy link
Owner

shuding commented Jul 22, 2022

I think it’s good to print the message 👍

We might need a quiet option in the future

@shuding shuding merged commit c751458 into shuding:core Jul 22, 2022
@dimaMachina dimaMachina deleted the ignore-loading-mdx-in-pages-api branch July 22, 2022 08:29
@dimaMachina dimaMachina mentioned this pull request Jul 22, 2022
Closed
tatukoivisto pushed a commit to tatukoivisto/nextra that referenced this pull request Aug 20, 2023
@dimaMachina @shuding
fix(nextra): ignore in loader files from pages/api folder (shuding#543
771ca34 
)

* fix(nextra): ignore loading markdown files in `pages/api` folder

* Update packages/nextra/src/loader.ts

* Create stale-chairs-relate.md

Co-authored-by: Shu Ding <g@shud.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dimaMachina @shuding