Fix: avoid mutating nextConfig #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8c9b234 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
I'm unable to see the logs for Vercel – nextra-theme-docs-dev |
promer94
requested changes
Jul 27, 2022
|
Done, but I would love to know the reason why it can't be defined under tsup.config.js as |
|
The Vercel – nextra-theme-docs-dev deployment is fixed now! |
dimaMachina
reviewed
Jul 27, 2022
Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
promer94
approved these changes
Jul 27, 2022
tatukoivisto
pushed a commit
to tatukoivisto/nextra
that referenced
this pull request
Aug 20, 2023
* Fix: avoid mutating nextConfig * Fix: pass defaulti18n to nextra/loader * Refactor: make i18n mutation easier to read * Refactor: migrate index to TS and create a default i18n * Fix add index.ts tsup * Revert migration to TS * fix: wrong entry * Update packages/nextra/src/index.js Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru> Co-authored-by: Shu Ding <g@shud.in> Co-authored-by: Yixuan Xu <yixuanxu94@outlook.com> Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating to beta.10, I got a TypeError on i18n.
This PR 'solves' the issue, but gives back a bunch of json-schema validation errors. I preferred to create a PR half-backed than open an issue.
Moved the file to TypeScript to avoid future problems. Not sure if it's desired, but I found myself doing something silly without TS, even in this PR.