fix `Hydration failed because the initial UI...` while adding custom `404.mdx`/`500.mdx` custom error pages #607

dimaMachina · 2022-07-28T00:25:16Z

related #603

~~update: swr-site build locally pass, can I have an error, please?~~

changeset-bot · 2022-07-28T00:25:18Z

⚠️ No Changeset found

Latest commit: 6c68df2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2022-07-28T00:25:18Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nextra-theme-docs-dev	✅ Ready (Inspect)	Visit Preview	Aug 9, 2022 at 9:20AM (UTC)

1 Ignored Deployment

Name	Status	Preview	Updated
nextra	⬜️ Ignored (Inspect)		Aug 9, 2022 at 9:20AM (UTC)

shuding

Can we filter error routes at the beginning of normalize-pages, e.g. here?

nextra/packages/nextra-theme-docs/src/utils/normalize-pages.tsx

Lines 113 to 122 in ef65eff

    
           const items = list 
        
             .filter( 
        
               a => 
        
                 // not meta 
        
                 a.name !== 'meta.json' && 
        
                 // not hidden routes 
        
                 !a.name.startsWith('_') && 
        
                 // locale matches, or fallback to default locale 
        
                 (a.locale === locale || a.locale === defaultLocale || !a.locale) 
        
             )

dimaMachina · 2022-08-08T11:19:29Z

packages/nextra-theme-docs/src/components/toc.tsx

-    case 'gitlab':
-      return `https://gitlab.com/${repo.owner}/${repo.name}/-/blob/${
-        repo.branch || 'master'
-      }/${repo.subdir || 'pages'}${filepath}`


seems like the previous GitLab issue link never worked.. it should be

nextra/packages/nextra-theme-docs/src/utils/get-git-issue-url.ts

Lines 20 to 23 in 9c7cde3

case 'gitlab':

return `https://gitlab.com/${repo.owner}/${

repo.name

}/-/issues/new?issue[title]=${encodeURIComponent(title)}`

dimaMachina · 2022-08-08T11:21:51Z

Can we filter error routes at the beginning of normalize-pages, e.g. here?

nextra/packages/nextra-theme-docs/src/utils/normalize-pages.tsx

Lines 113 to 122 in ef65eff

const items = list

.filter(

a =>

// not meta

a.name !== 'meta.json' &&

// not hidden routes

!a.name.startsWith('_') &&

// locale matches, or fallback to default locale

(a.locale === locale || a.locale === defaultLocale || !a.locale)

)

you were right, I found a better place!

Let me know what do you think ;)

https://nextra-theme-docs-rbfdnx0wf.vercel.sh/docs/404-500#500

shuding · 2022-08-08T12:02:43Z

packages/nextra-theme-docs/src/components/sidebar.tsx

@@ -147,20 +145,17 @@ interface SeparatorProps {
  topLevel: boolean
 }

-function Separator({ title, topLevel }: SeparatorProps) {
-  const hasTitle = title !== undefined


Herr I'm using !== undefined check because title can be an empty string ''

@shuding turned back, added small comment also

dimaMachina · 2022-08-08T12:18:50Z

packages/nextra-theme-docs/src/constants.tsx

+  notFoundLink() {
+    const config = useConfig()
+    const mounted = useMounted()
+    const { asPath } = useRouter()
+    return (
+      <Anchor
+        href={getGitIssueUrl({
+          repository: config.docsRepositoryBase,
+          title: `Found broken \`${mounted ? asPath : ''}\` link. Please fix!`,
+          labels: config.notFoundLabels
+        })}
+        newWindow
+      >
+        Submit an issue about broken link.
+      </Anchor>
+    )
+  },


I think a need to move <Anchor /> directly in <NotFoundPage />, same for <Anchor /> in serverSideErrorLink

Because in feedbackLink it's a child of <Anchor/>

shuding

Thanks!

…`404.mdx`/`500.mdx` custom error pages (#607) * fix * even yet better! * remove unused things * fix hasTitle * move notFoundLink and serverSideErrorLink directly to components

* fix `next export` command * replace `classnames` package with `clsx` as he's faster (#656) * remove `locale` prop from theme config, forbid passing `locale` prop in `renderComponent()` (#658) * remove `locale` prop from theme config, forbid passing in `renderComponent` * fix ci * fix `Warning: Prop `href` did not match. Server: "#" Client: ...` (#659) * update snapshots * update tests * fix `Hydration failed because the initial UI...` while adding custom `404.mdx`/`500.mdx` custom error pages (#607) * fix * even yet better! * remove unused things * fix hasTitle * move notFoundLink and serverSideErrorLink directly to components * rebase fixes * fix type check

* fix `next export` command * replace `classnames` package with `clsx` as he's faster (shuding#656) * remove `locale` prop from theme config, forbid passing `locale` prop in `renderComponent()` (shuding#658) * remove `locale` prop from theme config, forbid passing in `renderComponent` * fix ci * fix `Warning: Prop `href` did not match. Server: "#" Client: ...` (shuding#659) * update snapshots * update tests * fix `Hydration failed because the initial UI...` while adding custom `404.mdx`/`500.mdx` custom error pages (shuding#607) * fix * even yet better! * remove unused things * fix hasTitle * move notFoundLink and serverSideErrorLink directly to components * rebase fixes * fix type check

dimaMachina force-pushed the 404-500 branch from df3b8f6 to 0e404e2 Compare July 28, 2022 00:28

vercel bot had a problem deploying to Preview – nextra-theme-docs-dev July 28, 2022 00:28 Failure

dimaMachina mentioned this pull request Jul 28, 2022

404 Page does not let you navigate to any useful page the-guild-org/the-guild-docs#649

Closed

vercel bot had a problem deploying to Preview – nextra-theme-docs-dev July 28, 2022 13:22 Failure

vercel bot deployed to Preview – nextra-theme-docs-dev July 28, 2022 19:31 View deployment

dimaMachina requested a review from shuding July 29, 2022 09:28

This comment was marked as resolved.

Sign in to view

shuding reviewed Jul 29, 2022

View reviewed changes

dimaMachina marked this pull request as draft July 29, 2022 19:48

dimaMachina force-pushed the 404-500 branch from ef65eff to ce11fce Compare August 8, 2022 11:11

dimaMachina changed the base branch from core to fix-next-export August 8, 2022 11:11

vercel bot deployed to Preview – nextra-theme-docs-dev August 8, 2022 11:14 View deployment

fix

9c7cde3

dimaMachina force-pushed the 404-500 branch from ce11fce to 9c7cde3 Compare August 8, 2022 11:15

vercel bot deployed to Preview – nextra-theme-docs-dev August 8, 2022 11:17 View deployment

dimaMachina commented Aug 8, 2022

View reviewed changes

dimaMachina marked this pull request as ready for review August 8, 2022 11:21

dimaMachina requested a review from shuding August 8, 2022 11:22

even yet better!

c7f37e8

vercel bot deployed to Preview – nextra-theme-docs-dev August 8, 2022 11:34 View deployment

remove unused things

2e329b4

vercel bot deployed to Preview – nextra-theme-docs-dev August 8, 2022 11:38 View deployment

shuding reviewed Aug 8, 2022

View reviewed changes

fix hasTitle

47e7422

vercel bot deployed to Preview – nextra-theme-docs-dev August 8, 2022 12:09 View deployment

dimaMachina commented Aug 8, 2022

View reviewed changes

shuding approved these changes Aug 8, 2022

View reviewed changes

move notFoundLink and serverSideErrorLink directly to components

6c68df2

vercel bot deployed to Preview – nextra-theme-docs-dev August 9, 2022 09:20 View deployment

dimaMachina merged commit b397aa1 into fix-next-export Aug 9, 2022

dimaMachina deleted the 404-500 branch August 9, 2022 09:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix `Hydration failed because the initial UI...` while adding custom `404.mdx`/`500.mdx` custom error pages #607

fix `Hydration failed because the initial UI...` while adding custom `404.mdx`/`500.mdx` custom error pages #607

dimaMachina commented Jul 28, 2022 •

edited

changeset-bot bot commented Jul 28, 2022 •

edited

vercel bot commented Jul 28, 2022 •

edited

This comment was marked as resolved.

shuding left a comment

dimaMachina Aug 8, 2022

dimaMachina commented Aug 8, 2022 •

edited

shuding Aug 8, 2022

dimaMachina Aug 8, 2022 •

edited

dimaMachina Aug 8, 2022 •

edited

shuding left a comment

	const items = list
	.filter(
	a =>
	// not meta
	a.name !== 'meta.json' &&
	// not hidden routes
	!a.name.startsWith('_') &&
	// locale matches, or fallback to default locale
	(a.locale === locale \|\| a.locale === defaultLocale \|\| !a.locale)
	)

	case 'gitlab':
	return `https://gitlab.com/${repo.owner}/${
	repo.name
	}/-/issues/new?issue[title]=${encodeURIComponent(title)}`

fix Hydration failed because the initial UI... while adding custom 404.mdx/500.mdx custom error pages #607

fix Hydration failed because the initial UI... while adding custom 404.mdx/500.mdx custom error pages #607

Conversation

dimaMachina commented Jul 28, 2022 • edited

changeset-bot bot commented Jul 28, 2022 • edited

⚠️ No Changeset found

vercel bot commented Jul 28, 2022 • edited

This comment was marked as resolved.

shuding left a comment

Choose a reason for hiding this comment

dimaMachina Aug 8, 2022

Choose a reason for hiding this comment

dimaMachina commented Aug 8, 2022 • edited

shuding Aug 8, 2022

Choose a reason for hiding this comment

dimaMachina Aug 8, 2022 • edited

Choose a reason for hiding this comment

dimaMachina Aug 8, 2022 • edited

Choose a reason for hiding this comment

shuding left a comment

Choose a reason for hiding this comment

fix `Hydration failed because the initial UI...` while adding custom `404.mdx`/`500.mdx` custom error pages #607

fix `Hydration failed because the initial UI...` while adding custom `404.mdx`/`500.mdx` custom error pages #607

dimaMachina commented Jul 28, 2022 •

edited

changeset-bot bot commented Jul 28, 2022 •

edited

vercel bot commented Jul 28, 2022 •

edited

dimaMachina commented Aug 8, 2022 •

edited

dimaMachina Aug 8, 2022 •

edited

dimaMachina Aug 8, 2022 •

edited