Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split css to hamburger/scrollbar/typesetting-article css files #719

Merged
merged 12 commits into from Aug 27, 2022

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Aug 19, 2022

review only first commit

@vercel
Copy link

vercel bot commented Aug 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextra-theme-docs-dev ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 2:51PM (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 2:51PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
nextra ⬜️ Ignored (Inspect) Aug 26, 2022 at 2:51PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2022

🦋 Changeset detected

Latest commit: 0003761

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

)

* fix edit on github button for cases when filename named as `index`

* fix typecheck

* [docs] ❗️BREAKING ❗️ various theme config options was renamed (#721)

* rename `meta.json` to `_meta.json` (#722)

* BREAKING! various theme config options was renamed

* add new options `toc.component` to override toc component #564

* rename editLink to editLinkText

* add helpful console warnings

* Update packages/nextra-theme-docs/src/contexts/config.tsx

* Update packages/nextra-theme-docs/src/components/footer.tsx

* fix project.link behaviour

* small fix

* fix

* rename `meta.json` to `_meta.json`

* update snapshots

* rename `PageOpts.meta` to `PageOpts.frontMatter` (#723)

* BREAKING! various theme config options was renamed

* add new options `toc.component` to override toc component #564

* rename editLink to editLinkText

* add helpful console warnings

* Update packages/nextra-theme-docs/src/contexts/config.tsx

* Update packages/nextra-theme-docs/src/components/footer.tsx

* fix project.link behaviour

* small fix

* fix

* rename `meta.json` to `_meta.json`

* update snapshots

* rename `PageOpts.meta` to `PageOpts.frontMatter`

* fix swr build

* small fix

* clicking on folder should navigate to first children if `index` page doesn't exist (#724)

* BREAKING! various theme config options was renamed

* add new options `toc.component` to override toc component #564

* rename editLink to editLinkText

* add helpful console warnings

* Update packages/nextra-theme-docs/src/contexts/config.tsx

* Update packages/nextra-theme-docs/src/components/footer.tsx

* fix project.link behaviour

* small fix

* fix

* rename `meta.json` to `_meta.json`

* update snapshots

* rename `PageOpts.meta` to `PageOpts.frontMatter`

* fix swr build

* small fix

* clicking on folder should navigate to first children if `index` page doesn't exist

* apply review changes

* rebase fixes
* adjust active breadcrumb color

* move `withLayout` logic directly in nextra loader
@dimaMachina
Copy link
Collaborator Author

@shuding swr-site build locally passes, seems like ci glitch?

@shuding
Copy link
Owner

shuding commented Aug 25, 2022

It looks like a build error though:


TypeError: Cannot read properties of null (reading 'useContext')
00:24:23	    at Object.exports.useContext (/vercel/path0/node_modules/.pnpm/react@18.2.0/node_modules/react/cjs/react.production.min.js:24:118)
00:24:23	    at useRouter (/vercel/path0/node_modules/.pnpm/next@12.2.4_biqbaboplfbrettd7655fr4n2y/node_modules/next/dist/client/router.js:120:27)
00:24:23	    at Layout (/vercel/path0/examples/swr-site/.next/server/chunks/5252.js:2866:42)
00:24:23	    at Module.4489 (/vercel/path0/examples/swr-site/.next/server/pages/about/a-page.en-US.js:574:137)
00:24:23	    at __webpack_require__ (/vercel/path0/examples/swr-site/.next/server/webpack-runtime.js:25:43)
00:24:23	    at __webpack_exec__ (/vercel/path0/examples/swr-site/.next/server/pages/about/a-page.en-US.js:826:39)
00:24:23	    at /vercel/path0/examples/swr-site/.next/server/pages/about/a-page.en-US.js:827:77
00:24:23	    at Function.__webpack_require__.X (/vercel/path0/examples/swr-site/.next/server/webpack-runtime.js:120:21)
00:24:23	    at /vercel/path0/examples/swr-site/.next/server/pages/about/a-page.en-US.js:827:47
00:24:23	    at Object.<anonymous> (/vercel/path0/examples/swr-site/.next/server/pages/about/a-page.en-US.js:830:3)
00:24:23	
00:24:23	> Build error occurred
00:24:23	Error: Failed to collect page data for /about/a-page.en-US
00:24:23	    at /vercel/path0/node_modules/.pnpm/next@12.2.4_biqbaboplfbrettd7655fr4n2y/node_modules/next/dist/build/utils.js:644:15
00:24:23	    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
00:24:23	  type: 'Error'
00:24:23	}

(I'll try to make the preview project public so everyone can see it!)

@dimaMachina
Copy link
Collaborator Author

@shuding fixed, this was a glitch, but after merge another PR there was a real issue :)

@shuding
Copy link
Owner

shuding commented Aug 27, 2022

Thanks!

dimaMachina added a commit that referenced this pull request Aug 28, 2022
* refactor toc, fix toc's styles on rtl, use `ref.current` instead `document.getElementsByClassName`

* group both `mask-image`

* fix search overlay styles on mobile

* fix

* split css to `hamburger`/`scrollbar`/`typesetting-article` css files (#719)

* split css to `hamburger`/`scrollbar`/`typesetting-article` css files

* fix edit on github button for cases when filename named as `index` (#720)

* fix edit on github button for cases when filename named as `index`

* fix typecheck

* [docs] ❗️BREAKING ❗️ various theme config options was renamed (#721)

* rename `meta.json` to `_meta.json` (#722)

* BREAKING! various theme config options was renamed

* add new options `toc.component` to override toc component #564

* rename editLink to editLinkText

* add helpful console warnings

* Update packages/nextra-theme-docs/src/contexts/config.tsx

* Update packages/nextra-theme-docs/src/components/footer.tsx

* fix project.link behaviour

* small fix

* fix

* rename `meta.json` to `_meta.json`

* update snapshots

* rename `PageOpts.meta` to `PageOpts.frontMatter` (#723)

* BREAKING! various theme config options was renamed

* add new options `toc.component` to override toc component #564

* rename editLink to editLinkText

* add helpful console warnings

* Update packages/nextra-theme-docs/src/contexts/config.tsx

* Update packages/nextra-theme-docs/src/components/footer.tsx

* fix project.link behaviour

* small fix

* fix

* rename `meta.json` to `_meta.json`

* update snapshots

* rename `PageOpts.meta` to `PageOpts.frontMatter`

* fix swr build

* small fix

* clicking on folder should navigate to first children if `index` page doesn't exist (#724)

* BREAKING! various theme config options was renamed

* add new options `toc.component` to override toc component #564

* rename editLink to editLinkText

* add helpful console warnings

* Update packages/nextra-theme-docs/src/contexts/config.tsx

* Update packages/nextra-theme-docs/src/components/footer.tsx

* fix project.link behaviour

* small fix

* fix

* rename `meta.json` to `_meta.json`

* update snapshots

* rename `PageOpts.meta` to `PageOpts.frontMatter`

* fix swr build

* small fix

* clicking on folder should navigate to first children if `index` page doesn't exist

* apply review changes

* rebase fixes

* adjust active breadcrumb color (#725)

* move `withLayout` logic directly in nextra loader (#726)

* adjust active breadcrumb color

* move `withLayout` logic directly in nextra loader

* better loader types, add `MetaJsonFile`, `MdxFile`, `Folder` types, add tests for `next/context` (#731)

* fix ci

* fix callout shrinking from children content (#746)

* Version Packages (beta) (#728)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix typecheck

* fix typecheck

* simplify

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
tatukoivisto pushed a commit to tatukoivisto/nextra that referenced this pull request Aug 20, 2023
* refactor toc, fix toc's styles on rtl, use `ref.current` instead `document.getElementsByClassName`

* group both `mask-image`

* fix search overlay styles on mobile

* fix

* split css to `hamburger`/`scrollbar`/`typesetting-article` css files (shuding#719)

* split css to `hamburger`/`scrollbar`/`typesetting-article` css files

* fix edit on github button for cases when filename named as `index` (shuding#720)

* fix edit on github button for cases when filename named as `index`

* fix typecheck

* [docs] ❗️BREAKING ❗️ various theme config options was renamed (shuding#721)

* rename `meta.json` to `_meta.json` (shuding#722)

* BREAKING! various theme config options was renamed

* add new options `toc.component` to override toc component shuding#564

* rename editLink to editLinkText

* add helpful console warnings

* Update packages/nextra-theme-docs/src/contexts/config.tsx

* Update packages/nextra-theme-docs/src/components/footer.tsx

* fix project.link behaviour

* small fix

* fix

* rename `meta.json` to `_meta.json`

* update snapshots

* rename `PageOpts.meta` to `PageOpts.frontMatter` (shuding#723)

* BREAKING! various theme config options was renamed

* add new options `toc.component` to override toc component shuding#564

* rename editLink to editLinkText

* add helpful console warnings

* Update packages/nextra-theme-docs/src/contexts/config.tsx

* Update packages/nextra-theme-docs/src/components/footer.tsx

* fix project.link behaviour

* small fix

* fix

* rename `meta.json` to `_meta.json`

* update snapshots

* rename `PageOpts.meta` to `PageOpts.frontMatter`

* fix swr build

* small fix

* clicking on folder should navigate to first children if `index` page doesn't exist (shuding#724)

* BREAKING! various theme config options was renamed

* add new options `toc.component` to override toc component shuding#564

* rename editLink to editLinkText

* add helpful console warnings

* Update packages/nextra-theme-docs/src/contexts/config.tsx

* Update packages/nextra-theme-docs/src/components/footer.tsx

* fix project.link behaviour

* small fix

* fix

* rename `meta.json` to `_meta.json`

* update snapshots

* rename `PageOpts.meta` to `PageOpts.frontMatter`

* fix swr build

* small fix

* clicking on folder should navigate to first children if `index` page doesn't exist

* apply review changes

* rebase fixes

* adjust active breadcrumb color (shuding#725)

* move `withLayout` logic directly in nextra loader (shuding#726)

* adjust active breadcrumb color

* move `withLayout` logic directly in nextra loader

* better loader types, add `MetaJsonFile`, `MdxFile`, `Folder` types, add tests for `next/context` (shuding#731)

* fix ci

* fix callout shrinking from children content (shuding#746)

* Version Packages (beta) (shuding#728)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix typecheck

* fix typecheck

* simplify

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants