Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Docs #734

Merged
merged 16 commits into from Sep 10, 2022
Merged

[v2] Docs #734

merged 16 commits into from Sep 10, 2022

Conversation

shuding
Copy link
Owner

@shuding shuding commented Aug 22, 2022

As you can see there is now a v2 docs deployment:

CleanShot 2022-08-22 at 01 58 08@2x

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2022

🦋 Changeset detected

Latest commit: 299c7c5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextra-theme-docs-dev ✅ Ready (Inspect) Visit Preview Sep 10, 2022 at 9:59PM (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview Sep 10, 2022 at 9:59PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
nextra ⬜️ Ignored (Inspect) Sep 10, 2022 at 9:59PM (UTC)

@dimaMachina
Copy link
Collaborator

dimaMachina commented Aug 22, 2022

This landing page looks so modern

Follow elements should be adjusted
B286F071-C67A-479B-A7A7-12BF471FD457
57A38CBF-5104-430A-9D89-9D0FC5B467A6

@jermanuts
Copy link

jermanuts commented Sep 4, 2022

image
image
text is not visible when using dark mode

https://secsite.vercel.app/docs#quick-start Cards when using dark theme needs to have higher contrast :)
(weird that this bug is not on the official deploy https://nextra-v2-7i1dc7f7d-shuding1.vercel.app/ )

It was a bit confusing seeing https://nextra.vercel.app/themes/docs "This website is built with the docs theme." while in the repo it says https://github.com/shuding/nextra#themes (swr-site theme) which is different from nextra.vercel.app current theme.

Nextra right now have 3 themes.
Also, do you think v2 Docs is stable when using it like the same features in swr-site?

Good luck, it looks amazing. Wishing the best.

@dimaMachina
Copy link
Collaborator

Good luck, it looks amazing. Wishing the best.

@jermanuts thank you! We almost done 🤘

* explain why table is rendered differently

* fix
@shuding shuding linked an issue Sep 10, 2022 that may be closed by this pull request
8 tasks
@shuding
Copy link
Owner Author

shuding commented Sep 10, 2022

Thanks for all the reviews, I also did some changes to the core in this PR that is also noted in #826. The docs is still unfinished but since it's still a preview deployment, I think we can ship this first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename configurations
3 participants