fix covered select options #803
Conversation
🦋 Changeset detectedLatest commit: 5c51e72 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
I think that popup is right-aligned currently, did we run into an issue with that? |
|
@shuding it’s right aligned but in the latest PR with hided sidebar without this PR popup (switch language or theme) will be covered since container width is too small |
|
Ah that makes sense! |
Do we really need it? Because on mobile this will be extra expanded, more info in my comment If you still prefer extra expanded I’ll change it |
|
Got it! I think then we only make it extend on desktop? |
| <> | ||
| <script | ||
| dangerouslySetInnerHTML={{ | ||
| __html: `document.documentElement.setAttribute('dir','${direction}')` |
There was a problem hiding this comment.
Makes sense! Does it work when the language changes like from LTR to RTL?
There was a problem hiding this comment.
yeah it works, also there is no shrinking on initial loading
|
will convert it to draft until I apply your suggestion Updatewill fix in on merged PR |
* better focus ui, use ring color as theme hue color * Update packages/nextra-theme-docs/src/components/sidebar.tsx * Update packages/nextra-theme-docs/src/mdx-components.tsx * fix covered select options (#803) * fix covered select options * remove popper.tsx (was created for test purposes) * merge fixes * rebase fixes * works * fixes
* better focus ui, use ring color as theme hue color * Update packages/nextra-theme-docs/src/components/sidebar.tsx * Update packages/nextra-theme-docs/src/mdx-components.tsx * fix covered select options (shuding#803) * fix covered select options * remove popper.tsx (was created for test purposes) * merge fixes * rebase fixes * works * fixes
there is no way without using react portal
more info tailwindlabs/headlessui#59