Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not add placeholder="blur" on .svg static images #832

Merged
merged 1 commit into from Sep 11, 2022

Conversation

dimaMachina
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Sep 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextra-theme-docs-dev ✅ Ready (Inspect) Visit Preview Sep 11, 2022 at 5:05PM (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview Sep 11, 2022 at 5:05PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
nextra ⬜️ Ignored (Inspect) Sep 11, 2022 at 5:05PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2022

🦋 Changeset detected

Latest commit: 28f2926

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +202 to +209
titleComponent: ({ title, type }) =>
type === "separator" ? (
<div className="flex items-center gap-2">
<Logo className="h-1.5 shrink-0" />
{title}
</div>
) : (
<>{title}</>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes
image

@@ -82,7 +82,7 @@ export const remarkStaticImage: Plugin<
name: 'alt',
value: node.alt
},
{
!url.endsWith('.svg') && {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this, will get an error
image

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@dimaMachina dimaMachina marked this pull request as ready for review September 11, 2022 17:06
@dimaMachina dimaMachina merged commit d7e7f5b into core Sep 11, 2022
@dimaMachina dimaMachina deleted the do-not-apply-blur-on-svg branch September 11, 2022 17:07
tatukoivisto pushed a commit to tatukoivisto/nextra that referenced this pull request Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants