Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More docs work #839

Merged
merged 9 commits into from
Dec 1, 2022
Merged

More docs work #839

merged 9 commits into from
Dec 1, 2022

Conversation

shuding
Copy link
Owner

@shuding shuding commented Sep 12, 2022

Added the basic structure for the "Page Configuration" page.

@vercel
Copy link

vercel bot commented Sep 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextra-theme-docs-dev ✅ Ready (Inspect) Visit Preview Dec 1, 2022 at 1:23AM (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview Dec 1, 2022 at 1:23AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
nextra ⬜️ Ignored (Inspect) Dec 1, 2022 at 1:23AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2022

🦋 Changeset detected

Latest commit: 7962aaf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jermanuts
Copy link

jermanuts commented Sep 13, 2022

swr.vercel.app currently have a bug when you use the search tab and close it. It won't actually close but become invisible, if your cursor hover over it's drop down menu, you won't be able to scroll.
image
However, this is not a problem on latest (nextra-theme-docs-dev) release.

Tabs at nextra-v2 are not seperated which causes npm and yarn to be with pnpm https://nextra-v2-git-shu-agay-shuding1.vercel.app/docs/docs-theme/start#ready-to-go . Both yarn and npm is have pnpm dev menu which should be npm run dev and yarn dev instead.

An example with docusaurus. astronomer git repo which renders well https://docs.astronomer.io/astro/cli/configure-cli?tab=mac#install-the-astro-cli

CMS on the sidebar under guide section page is removed.

FAQ drop menu (community) is missing https://nextra-v2-git-shu-agay-shuding1.vercel.app/docs/about#/community

Good luck!

@jermanuts
Copy link

jermanuts commented Sep 13, 2022

https://nextra-v2-git-shu-agay-shuding1.vercel.app/docs/docs-theme/theme-configuration#dynamic-tags-based-on-page , use-config is missing from sidebar API section.

https://github.com/shuding/nextra/blob/shu/agay/docs/pages/docs/docs-theme/page-configuration.mdx?plain=1#L3 , to In Nextra, a page can be configured via the [_meta.json](/docs/guide/organize-files#_metajson) file. With the docs theme, some extra options are available to customize the structure further.

@shuding shuding merged commit a1c1e4e into core Dec 1, 2022
@shuding shuding deleted the shu/agay branch December 1, 2022 01:23
tatukoivisto pushed a commit to tatukoivisto/nextra that referenced this pull request Aug 20, 2023
* wip

* add changeset

* add more

* more content

* fix props

* fix lint errors

* simplify ci

* fix lint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants