Add nx- tailwind prefix
#911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5ae1bcb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
cc @B2o5T this is a pretty big refactoring and it will affect some other PRs 🙏 (however this should not break users' code unless they're doing something wrong) |
tatukoivisto
pushed a commit
to tatukoivisto/nextra
that referenced
this pull request
Aug 20, 2023
* add nx- tailwind prefix * update * fix dark mode * add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to isolate these classnames in case the website itself also uses Tailwind.
Seems like dark + prefix doesn't always work:changing todark:nx-shadow-[0_-12px_16px_#111]darkMode: ['class', 'html[class~="dark"]']fixes it, see tailwindlabs/tailwindcss#5754