Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make nextra/nextra-theme-docs be compatible with next 13 #946

Merged
merged 6 commits into from Nov 29, 2022
Merged

make nextra/nextra-theme-docs be compatible with next 13 #946

merged 6 commits into from Nov 29, 2022

Conversation

dimaMachina
Copy link
Collaborator

fixes #935

@vercel
Copy link

vercel bot commented Oct 27, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextra 🔄 Building (Inspect) Nov 29, 2022 at 11:52AM (UTC)
nextra-theme-docs-dev ✅ Ready (Inspect) Visit Preview Nov 29, 2022 at 11:52AM (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview Nov 29, 2022 at 11:52AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2022 •
edited

🦋 Changeset detected

Latest commit: 2c8797a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

shuding
shuding approved these changes Oct 29, 2022
View reviewed changes
Copy link
Owner

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danielschuster-muc danielschuster-muc mentioned this pull request Oct 29, 2022
Closed
@dimaMachina
Copy link
Collaborator Author

dimaMachina commented Oct 29, 2022 •
edited

@shuding could you send the error from deploying?

@nathanhammond
Copy link
Contributor

@B2o5T the error is "Error: No serverless pages were built" I suspect that the find-pages-dir change may have issues.

@ttwrpz ttwrpz mentioned this pull request Nov 11, 2022
Closed
@Subham-Maity Subham-Maity mentioned this pull request Nov 17, 2022
Closed
@shuding
Copy link
Owner

shuding commented Nov 27, 2022

Sorry for the delay @B2o5T! I'll make these project public and help investigate the error here.

dimaMachina
dimaMachina commented Nov 29, 2022
View reviewed changes
docs/package.json Outdated
Comment on lines 13 to 15
"next": "^12.2.3",
"next": "^13.0.0",
"nextra": "2.0.0-beta.25",
"nextra-theme-docs": "2.0.0-beta.25",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated docs to v13 but nextra installed in docs (2.0.0-beta.25) don't support it yet 😂, will push a fixes today (also fixed locales.tsx in nextra, since request.cookies was changed in v13)

@dimaMachina
Copy link
Collaborator Author

@shuding should be fine now, you can review my last commit, I made nextra-theme-blog compatible too

@shuding shuding merged commit 59e18b0 into core Nov 29, 2022
@shuding shuding deleted the next13 branch November 29, 2022 15:12
@shuding
Copy link
Owner

shuding commented Nov 29, 2022

Thank you!

tatukoivisto pushed a commit to tatukoivisto/nextra that referenced this pull request Aug 20, 2023
@dimaMachina @shuding
make nextra/nextra-theme-docs be compatible with next 13 (shuding…
1b38941 
…#946)

* make `nextra`/`nextra-theme-docs` be compatible with next 13

* fix docs

* make project public

* fix

* fixes

* Update curvy-yaks-protect.md

Co-authored-by: Shu Ding <g@shud.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dimaMachina @nathanhammond @shuding