Fix incorrect width computation for text that can't wrap #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some reproductions of the issue: https://codesandbox.io/s/react-wrap-balancer-bug-ubbizi
The problem is that if the text can't wrap, the container's height will never change as we shrink the wrapper. So we keep shrinking the wrapper, never observe a height change, and end up with a width lower than the minimum required to not overflow the container.
I solved it by making sure
lower
is no less than the minimum width necessary to fit the contents (seescrollWidth
documentation).Ideally you wouldn't give
react-wrap-balancer
text that can't wrap in the first place, but sometimes you're getting arbitrary titles from somewhere and you don't know if they are single words or have non-breaking spaces so we should probably handle this case in the package.