Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: react under 18 support. #62

Merged
merged 1 commit into from
May 9, 2023
Merged

feat: react under 18 support. #62

merged 1 commit into from
May 9, 2023

Conversation

okinawaa
Copy link
Contributor

@okinawaa okinawaa commented May 7, 2023

implement #38

Thank you for providing a good library.

We only use the function useId which react 18 gave, but it is regrettable that the user under react18 version cannot use react-wrap-balancer.
I tried to modify the code to make useId polyfill to satisfy past version.

Thank you.

@vercel
Copy link

vercel bot commented May 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-wrap-balancer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2023 10:12am

@shuding
Copy link
Owner

shuding commented May 9, 2023

Thanks, this implementation looks good to me!

@shuding shuding merged commit feb611b into shuding:main May 9, 2023
1 check passed
@shuding shuding mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants