Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix types for all entries #20

Merged
merged 7 commits into from
Feb 23, 2023
Merged

fix types for all entries #20

merged 7 commits into from
Feb 23, 2023

Conversation

jeetiss
Copy link
Collaborator

@jeetiss jeetiss commented Feb 22, 2023

@cc-bbohlender could you check if this solution works for you?

I packed the package, so you can download the file, install, and test types.

@jeetiss
Copy link
Collaborator Author

jeetiss commented Feb 22, 2023

i test this PR with https://arethetypeswrong.github.io/ and the problem with node resolution is still here 😢

Снимок экрана 2023-02-22 в 14 25 54

@jeetiss
Copy link
Collaborator Author

jeetiss commented Feb 22, 2023

typeVersions did the job and it works now (i update the file in description, so you still can test it)

Снимок экрана 2023-02-22 в 14 43 24

@bbohlender
Copy link
Contributor

@jeetiss Thanks, works perfect.
I tested the wasm and asm version both with node version 18.12.1 and 16.8.0 and moduleResolution NodeNext.

I also tested the asm and wasm version with the normal "node" module resolution and node 18.12.1.

The tests I am using include the following

set & get properties
✔ it should throw an error
✔ should get raw vaues
✔ it should set new values
✔ it should reset all values

add, remove & reorder children & layout
✔ add children in order
✔ change children order
✔ change nothing
✔ remove child & destroy before commit
✔ remove child & destroy after commit
✔ use percentage
✔ use absolute value
✔ should not change anything depending on the properties previously set

@shuding shuding merged commit 68ce85a into main Feb 23, 2023
@shuding shuding deleted the fix-ts branch February 23, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants