Update yoga to support flex gap #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for some reason @flow doesn't work in `yoga/javascript/sources/YGEnums`, so force flag fix that problem
and satori throws next error: ``` TypeError: c[(p + 1)].Eb is not a function ❯ yoga-wasm-web/dist/yoga.mjs:67:295 ❯ _ yoga-wasm-web/dist/yoga.mjs:66:504 ❯ W.<anonymous> yoga-wasm-web/dist/yoga.mjs:40:52 ❯ W.<anonymous> yoga-wasm-web/dist/entry.js:1:4518 ❯ O.E.<computed> [as calculateLayout] yoga-wasm-web/dist/entry.js:1:3108 ❯ Module.satori src/satori.ts:160:7 ```
|
Please check #4 first it contains a lot of improvements for |
|
Amazing observation about the absolute positioning bug, thank you! |
shuding
reviewed
Nov 6, 2022
| @@ -9,7 +9,6 @@ wasm: | |||
| -g0 \ | |||
| -O2 \ | |||
| -flto \ | |||
| --closure 1 \ | |||
There was a problem hiding this comment.
Why removing this flag? I think it makes the binding smaller I just saw the USE_CLOSURE_COMPILER flag.
shuding
added a commit
to vercel/satori
that referenced
this pull request
Jan 9, 2023
hello, I'm experimenting with [`yoga-wasm-web`](https://github.com/shuding/yoga-wasm-web) to support gaps in flexbox and it works 🙌🏻 it looks like WIP because I can't fix types and add mess `@ts-ignore` everywhere EDIT: I compiled the new version of shuding/yoga-wasm-web#3 and I was so excited about it that I failed to explain what I actually did) Co-authored-by: Shu Ding <g@shud.in>
Onengakushimoto
added a commit
to Onengakushimoto/minial-vue
that referenced
this pull request
Jan 26, 2024
hello, I'm experimenting with [`yoga-wasm-web`](https://github.com/shuding/yoga-wasm-web) to support gaps in flexbox and it works 🙌🏻 it looks like WIP because I can't fix types and add mess `@ts-ignore` everywhere EDIT: I compiled the new version of shuding/yoga-wasm-web#3 and I was so excited about it that I failed to explain what I actually did) Co-authored-by: Shu Ding <g@shud.in>
HiraRyoko
added a commit
to HiraRyoko/minial-vue
that referenced
this pull request
Mar 21, 2024
hello, I'm experimenting with [`yoga-wasm-web`](https://github.com/shuding/yoga-wasm-web) to support gaps in flexbox and it works 🙌🏻 it looks like WIP because I can't fix types and add mess `@ts-ignore` everywhere EDIT: I compiled the new version of shuding/yoga-wasm-web#3 and I was so excited about it that I failed to explain what I actually did) Co-authored-by: Shu Ding <g@shud.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I manage to build a fresh version of yoga
absoluteposition doesn't work, I think it was broken because of outdated constants inYGEnums.jsfile. it was fixed here facebook/yoga@5a18ccd#diff-e7e9b48fa242a44e79d3aba89325057e4014f3acc7b0c14e808519acfb2ab225R86-R89